Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1f8M5i-0002ZK-Us
	for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Apr 2018 08:35:55 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1f8M5h-00012q-IO
	for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Apr 2018 08:35:53 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <fujita.etsuro@lab.ntt.co.jp>)
	id 1f8M5h-00012f-7m
	for pgsql-hackers@lists.postgresql.org; Tue, 17 Apr 2018 08:35:53 +0000
Received: from tama500.ecl.ntt.co.jp ([129.60.39.148])
	by makus.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <fujita.etsuro@lab.ntt.co.jp>)
	id 1f8M5Z-0003O2-IF
	for pgsql-hackers@postgresql.org; Tue, 17 Apr 2018 08:35:52 +0000
Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153])
	by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w3H8Zdoc012207;
	Tue, 17 Apr 2018 17:35:39 +0900
Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1])
	by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id B9949EA7F2D;
	Tue, 17 Apr 2018 17:35:39 +0900 (JST)
Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp
 [129.60.87.134])
	by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id AF20EEA7E85;
	Tue, 17 Apr 2018 17:35:39 +0900 (JST)
Received: from [IPv6:::1] (unknown [129.60.241.75])
	by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id AA4FC400934;
	Tue, 17 Apr 2018 17:35:39 +0900 (JST)
Message-ID: <5AD5B1E0.8020404@lab.ntt.co.jp>
Date: Tue, 17 Apr 2018 17:35:44 +0900
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:11.0) Gecko/20120327 Thunderbird/11.0.1
MIME-Version: 1.0
Subject: Re: Expression errors with "FOR UPDATE" and postgres_fdw with
 partition
 wise join enabled.
References: 
 <CAKcux6ktu-8tefLWtQuuZBYFaZA83vUzuRd7c1YHC-yEWyYFpg@mail.gmail.com>
 <CAFjFpRfD5=LsOqG1eUf-vMpm9KoEZBBGJo68D9wkUBJxop_emQ@mail.gmail.com>
 <CAFjFpReD2rwzw64T5ZHS9+S8avREuazLu4nnCRAXToUN=WC+-Q@mail.gmail.com>
In-Reply-To: 
 <CAFjFpReD2rwzw64T5ZHS9+S8avREuazLu4nnCRAXToUN=WC+-Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-CC-Mail-RelayStamp: 1
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
X-TM-AS-MML: disable
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

(2018/02/20 18:13), Ashutosh Bapat wrote:
> Here's patchset implementing this solution.
>
> 0001 adds PVC_*_CONVERTROWTYPEEXPR to pull_var_clause() and adjusts its callers.
>
> 0002 fixes a similar bug for regular partitioned tables. The patch has
> testcase. The commit message explains the bug in more detail.
>
> 0003 has postgres_fdw fixes as outlined above with tests.

The patch 0003 doesn't applies to the latest HEAD any more, so please 
update the patch.  I think this should be an open item for PG11.  My 
apologizes for not having reviewed the patch in the last commitfest.

Best regards,
Etsuro Fujita