public inbox for [email protected]  

help / color / mirror / Atom feed
From: Chao Li <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Reduce log level of some logical decoding messages to DEBUG1
Date: Wed, 1 Apr 2026 15:30:40 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHGQGwHhesQa5KSR76OGxRok0P=_JBstSUGsKUVP-_ZuTjXPQw@mail.gmail.com>
References: <CAHGQGwGTyHgtD9tyN664x6vQ8Q1G53H7ZUCgBU9_X=nLt3f1QA@mail.gmail.com>
	<CALj2ACX_SSJYKt5od1C2874yeotTO9JewfRY9B=3DYx2daUAMw@mail.gmail.com>
	<CAHGQGwHTuLKTmW5DHtx-5yMuEq4=fc7M+UuvdOVekyvfsi=48Q@mail.gmail.com>
	<CAHGQGwFB+hC97SHDpn1vOHHOq9uM5OZZmt50j7v6Z1JUNtH5zQ@mail.gmail.com>
	<CALj2ACXwe+iVoE50epmfGahYfoeBadgRr8ADvNHshWn0svv9hw@mail.gmail.com>
	<CAHGQGwHUK6gMxF_dO2ei7xFt6ncegACi82BHq4zCMsBuVkxd_w@mail.gmail.com>
	<CAHGQGwHhesQa5KSR76OGxRok0P=_JBstSUGsKUVP-_ZuTjXPQw@mail.gmail.com>



> On Apr 1, 2026, at 14:48, Fujii Masao <[email protected]> wrote:
> 
> On Wed, Mar 25, 2026 at 2:54 PM Fujii Masao <[email protected]> wrote:
>>> Perhaps, we could wait
>>> for some time to hear from others.
>> 
>> +1.
>> 
>> If there are no further comments in the next few days, and given the limited
>> time before feature freeze, I'm inclined to at least apply the 0001 patch
>> (which simply lowers the log level to DEBUG1).
> 
> Since there were no objections for about a week, I've pushed the 0001
> patch. Thanks!
> 
> If any issues or concerns are raised, let's consider applying the 0002 patch!
> 
> Regards,
> 
> -- 
> Fujii Masao

TBH, I’m not quite sure what practical benefit this patch set provides.

In 0001, some messages are changed from LOG to DEBUG1. But then 0002 introduces trace_logical_decoding_messages, whose default is DEBUG1, so with the default setting those messages are effectively promoted back to LOG again. That seems to cancel out the behavior change from 0001 by default.

Also, looking at where trace_logical_decoding() is applied in 0002, all the call sites currently pass DEBUG1. So in practice, if a user sets trace_logical_decoding_messages to anything higher than DEBUG1, all of those messages disappear. That makes it feel more like an on/off switch than a mechanism for filtering messages by level.

So at least to me, the overall value of this patch is still not very clear.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/









view thread (10+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Reduce log level of some logical decoding messages to DEBUG1
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox