Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1faX6d-0003xy-Da for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Jul 2018 02:01:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1faX6b-0007U8-37 for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Jul 2018 02:01:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1faX6a-0007Tx-SX for pgsql-hackers@lists.postgresql.org; Wed, 04 Jul 2018 02:01:16 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1faX6Y-0004Ta-78 for pgsql-hackers@postgresql.org; Wed, 04 Jul 2018 02:01:16 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w64214ja010303; Wed, 4 Jul 2018 11:01:04 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 6A6DF639959; Wed, 4 Jul 2018 11:01:04 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 3DBFB639958; Wed, 4 Jul 2018 11:01:04 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.75]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 2B4804001EA; Wed, 4 Jul 2018 11:01:04 +0900 (JST) Message-ID: <5B3C2A4E.5030901@lab.ntt.co.jp> Date: Wed, 04 Jul 2018 11:00:46 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 Subject: Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. References: <5AFC0865.8050802@lab.ntt.co.jp> <5AFD6580.5090308@lab.ntt.co.jp> <5AFE81CC.8000508@lab.ntt.co.jp> <5B17C5EC.1090602@lab.ntt.co.jp> <5B1E5071.1000704@lab.ntt.co.jp> <5B23A964.9020800@lab.ntt.co.jp> <5B28FB19.3090809@lab.ntt.co.jp> <20180703163519.tsigyic5xefunv74@alap3.anarazel.de> In-Reply-To: <20180703163519.tsigyic5xefunv74@alap3.anarazel.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Andres Freund Cc: Robert Haas , Ashutosh Bapat , Rajkumar Raghuwanshi , pgsql-hackers X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk (2018/07/04 1:35), Andres Freund wrote: > On 2018-06-22 10:58:28 -0400, Robert Haas wrote: >> On Tue, Jun 19, 2018 at 8:46 AM, Etsuro Fujita >> wrote: >>> Here is a patch for that. >> I think this approach is going to run into trouble if the level at >> which we have to apply the ConvertRowTypeExpr happens not to be a >> projection-capable node. > > What's the plan forward here? I still think that this approach would be the right way to go, so I plan to polish the patch. > This has been an open item for quite a > while. Robert, are you in agreement with this approach on a high level? > Who is going to drive this forward? I'm willing to do that if it's OK, but I'd like to get more feedback from Robert, Ashutosh or anyone else. Best regards, Etsuro Fujita