Message-ID: <5B62E70F.10400@lab.ntt.co.jp>
Date: Thu, 02 Aug 2018 20:12:15 +0900
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:11.0) Gecko/20120327 Thunderbird/11.0.1
MIME-Version: 1.0
Subject: Re: Expression errors with "FOR UPDATE" and postgres_fdw with
 partition
 wise join enabled.
References: <20180731203124.xuyvcahqgryn63mz@alvherre.pgsql>
 <5B619DA8.30801@lab.ntt.co.jp>
 <CA+TgmoZqQF1irUvkbd6+bxdRCMa8H=gpy-7=YUxQDmvWP37sOw@mail.gmail.com>
In-Reply-To: 
 <CA+TgmoZqQF1irUvkbd6+bxdRCMa8H=gpy-7=YUxQDmvWP37sOw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        Andres Freund <andres@anarazel.de>,
        Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>,
        Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Precedence: bulk

(2018/08/02 2:44), Robert Haas wrote:
> Tom, Ashutosh, and I all seem to agree that we shouldn't try to
> re-jigger things at create-plan time.  I think that a 3-1 consensus
> against your proposal is sufficient to say we shouldn't go that way.

Agreed.

> Now, here you've got a new approach which avoids that, which I have
> not yet reviewed.  I'll try to spend some time on it this afternoon,
> but really, I think it's too late for this.  This bug was reported in
> February, and we're supposed to be pushing 11 final out the door in
> not much more than a month.  Proposing a new approach in August is not
> good.

Agreed.

> Can't we just do what Ashutosh proposed for now and revisit
> this for v12?

I think that may be possible.

Best regards,
Etsuro Fujita