Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fsR1E-0000kt-Ph for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Aug 2018 11:09:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fsR1C-0000eX-KB for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Aug 2018 11:09:42 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fsR1C-0000eQ-0u for pgsql-hackers@lists.postgresql.org; Wed, 22 Aug 2018 11:09:42 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fsR15-0006UH-QP for pgsql-hackers@postgresql.org; Wed, 22 Aug 2018 11:09:39 +0000 Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w7MB9Lgv032438; Wed, 22 Aug 2018 20:09:21 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 38B8FEA8266; Wed, 22 Aug 2018 20:09:21 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 2D95FEA75E2; Wed, 22 Aug 2018 20:09:21 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.75]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 1DCF2400311; Wed, 22 Aug 2018 20:09:21 +0900 (JST) Message-ID: <5B7D4449.9090704@lab.ntt.co.jp> Date: Wed, 22 Aug 2018 20:08:57 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 Subject: Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. References: <5AFC0865.8050802@lab.ntt.co.jp> <5B55886F.5090906@lab.ntt.co.jp> <5B5712C8.9030404@lab.ntt.co.jp> <5B59BA55.30200@lab.ntt.co.jp> <5B619D23.4010000@lab.ntt.co.jp> <5358.1533241519@sss.pgh.pa.us> <5B64562A.9000404@lab.ntt.co.jp> <5B645868.6030609@lab.ntt.co.jp> <5B683F60.2070806@lab.ntt.co.jp> <5B717A7B.4010308@lab.ntt.co.jp> <5B739D46.6040000@lab.ntt.co.jp> <3585ad1d-d610-ad53-80e2-296050cd73f3@lab.ntt.co.jp> <5B74101B.9080402@lab.ntt.co.jp> <5B74E8C0.5040300@lab.ntt.co.jp> In-Reply-To: <5B74E8C0.5040300@lab.ntt.co.jp> Content-Type: multipart/mixed; boundary="------------000103050805080101040809" X-CC-Mail-RelayStamp: 1 To: Robert Haas Cc: Amit Langote , Tom Lane , Andres Freund , Ashutosh Bapat , Rajkumar Raghuwanshi , pgsql-hackers X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------000103050805080101040809 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit (2018/08/16 12:00), Etsuro Fujita wrote: > (2018/08/15 23:40), Robert Haas wrote: >> Given the comments from the RMT, and also on general principle, it >> seems like we really need to get on with committing something here. >> It's my understanding you plan to do that, since it's your patch. >> When? > > I plan to do that late next week as I'll go on leave until next Tuesday. I added the commit message. Please find attached an updated version of the patch. Does that make sense? If there are not objections, I'll push this tomorrow. Best regards, Etsuro Fujita --------------000103050805080101040809 Content-Type: text/x-diff; name="0001-Disable-support-for-partitionwise-joins-in-problemat.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Disable-support-for-partitionwise-joins-in-problemat.pa"; filename*1="tch"