Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fspMm-0000h8-VA for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Aug 2018 13:09:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fspE2-0005gr-Ls for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Aug 2018 13:00:34 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fspE2-0005gk-Ag for pgsql-hackers@lists.postgresql.org; Thu, 23 Aug 2018 13:00:34 +0000 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fspDx-0000bi-Ly for pgsql-hackers@postgresql.org; Thu, 23 Aug 2018 13:00:33 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w7ND0Il6008655; Thu, 23 Aug 2018 22:00:18 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 3B49C639461; Thu, 23 Aug 2018 22:00:18 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 2FB46639281; Thu, 23 Aug 2018 22:00:18 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.75]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 25A98400926; Thu, 23 Aug 2018 22:00:18 +0900 (JST) Message-ID: <5B7EB001.4010907@lab.ntt.co.jp> Date: Thu, 23 Aug 2018 22:00:49 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 Subject: Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. References: <5AFC0865.8050802@lab.ntt.co.jp> <5B5712C8.9030404@lab.ntt.co.jp> <5B59BA55.30200@lab.ntt.co.jp> <5B619D23.4010000@lab.ntt.co.jp> <5358.1533241519@sss.pgh.pa.us> <5B64562A.9000404@lab.ntt.co.jp> <5B645868.6030609@lab.ntt.co.jp> <5B683F60.2070806@lab.ntt.co.jp> <5B717A7B.4010308@lab.ntt.co.jp> <5B739D46.6040000@lab.ntt.co.jp> <3585ad1d-d610-ad53-80e2-296050cd73f3@lab.ntt.co.jp> <5B74101B.9080402@lab.ntt.co.jp> <5B74E8C0.5040300@lab.ntt.co.jp> <5B7D4449.9090704@lab.ntt.co.jp> In-Reply-To: <5B7D4449.9090704@lab.ntt.co.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Robert Haas Cc: Amit Langote , Tom Lane , Andres Freund , Ashutosh Bapat , Rajkumar Raghuwanshi , pgsql-hackers X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk (2018/08/22 20:08), Etsuro Fujita wrote: > (2018/08/16 12:00), Etsuro Fujita wrote: >> (2018/08/15 23:40), Robert Haas wrote: >>> Given the comments from the RMT, and also on general principle, it >>> seems like we really need to get on with committing something here. >>> It's my understanding you plan to do that, since it's your patch. >>> When? >> >> I plan to do that late next week as I'll go on leave until next Tuesday. > > I added the commit message. Please find attached an updated version of > the patch. Does that make sense? If there are not objections, I'll push > this tomorrow. I tried this today, but doing git behind the corporate firewall doesn't work. I don't know the clear cause of that, so I'll investigate that tomorrow. Best regards, Etsuro Fujita