Message-ID: <5B892C65.9050008@lab.ntt.co.jp>
Date: Fri, 31 Aug 2018 20:54:13 +0900
From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:11.0) Gecko/20120327 Thunderbird/11.0.1
MIME-Version: 1.0
Subject: Re: Expression errors with "FOR UPDATE" and postgres_fdw with
 partition
 wise join enabled.
References: 
 <CA+TgmoYhgEkcR1E-BMS-2G8A4_5z0bbN6vCO+uR7HyQCOsWpEw@mail.gmail.com>
 <5B717A7B.4010308@lab.ntt.co.jp>
 <CA+TgmoaNuWR-Krw9L2NOARNd7gJfHXwgOO8=8J4YAp+P4a1djA@mail.gmail.com>
 <5B739D46.6040000@lab.ntt.co.jp>
 <3585ad1d-d610-ad53-80e2-296050cd73f3@lab.ntt.co.jp>
 <5B74101B.9080402@lab.ntt.co.jp>
 <CA+TgmoZ9FH6zZiQVhJFtRhRW0R1bCubJAHWP38vEj0aFtjjRmg@mail.gmail.com>
 <5B74E8C0.5040300@lab.ntt.co.jp> <5B7D4449.9090704@lab.ntt.co.jp>
 <5B7EB001.4010907@lab.ntt.co.jp> <20180824024710.GH30782@paquier.xyz>
 <5B7FFC58.7060208@lab.ntt.co.jp>
 <C4D47C88-8DCD-4311-93AD-7AD2D9CE5585@postgresql.org>
 <5B8669F3.2070905@lab.ntt.co.jp> <5B87D414.5030702@lab.ntt.co.jp>
In-Reply-To: <5B87D414.5030702@lab.ntt.co.jp>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
To: "Jonathan S. Katz" <jkatz@postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>,
 Robert Haas <robertmhaas@gmail.com>,
        Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
        Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
        Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>,
        Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Precedence: bulk

(2018/08/30 20:25), Etsuro Fujita wrote:
> (2018/08/29 18:40), Etsuro Fujita wrote:
>> (2018/08/29 0:21), Jonathan S. Katz wrote:
>>>> On Aug 24, 2018, at 8:38 AM, Etsuro
>>>> Fujita<fujita.etsuro@lab.ntt.co.jp> wrote:
>>>> (2018/08/24 11:47), Michael Paquier wrote:
>>>>> On Thu, Aug 23, 2018 at 10:00:49PM +0900, Etsuro Fujita wrote:
>>>>>> I tried this today, but doing git behind the corporate firewall
>>>>>> doesn't
>>>>>> work. I don't know the clear cause of that, so I'll investigate that
>>>>>> tomorrow.
>>>>>
>>>>> You may be able to tweak that by using https as origin point or proper
>>>>> git proxy settings?
>>>>
>>>> Yeah, my proxy settings were not correct. With the help of my
>>>> colleagues Horiguchi-san and Yamada-san, I corrected them but still
>>>> can't clone the master repository. Running git with GIT_CURL_VERBOSE
>>>> shows that there is another issue in my terminal environment, so I'm
>>>> trying to resolve that.
>>>
>>> Are there any updates on getting this patch committed?
>>
>> That investigation has shown that the cause is my company firewall, not
>> my terminal environment; that firewall has to be configured to allow me
>> to access to that repository. So, I'm asking my company about that.
>
> I got the approval from my boss today, so I think that I can have that
> access soon.

I fixed typos in the commit message, which Alvaro pointed out off-list, 
and revised the message a little bit.  Also, I reread the patch and 
noticed that the latest version includes now-unnecessary regression test 
cases; those were added to the previous version 
(refuse-pwj-when-wrvs-involved-2.patch in [1]) to check that 
apply_scanjoin_target_to_paths() and create_ordinary_grouping_paths() 
work for cases where whole-row Vars are involved, because I modified 
those functions, but the latest version doesn't touch those functions 
anymore, so those test cases seems unnecessary.  So I removed those (no 
other changes), and committed the patch.

Best regards,
Etsuro Fujita

[1] https://www.postgresql.org/message-id/5B683F60.2070806%40lab.ntt.co.jp