Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmZpD-0003eP-E6 for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Jan 2019 07:53:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gmZpC-0003XC-1U for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Jan 2019 07:53:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmZpB-0003QJ-MD for pgsql-hackers@lists.postgresql.org; Thu, 24 Jan 2019 07:53:21 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gmZp3-0004a8-Q0 for pgsql-hackers@postgresql.org; Thu, 24 Jan 2019 07:53:20 +0000 Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x0O7rBw6024481 for ; Thu, 24 Jan 2019 16:53:11 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id AA42CEA7CCE for ; Thu, 24 Jan 2019 16:53:11 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 9AAE8EA799B for ; Thu, 24 Jan 2019 16:53:11 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.75]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 771284003B0 for ; Thu, 24 Jan 2019 16:53:11 +0900 (JST) Message-ID: <5C496ED9.8040003@lab.ntt.co.jp> Date: Thu, 24 Jan 2019 16:52:57 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 Subject: Re: postgres_fdw: oddity in costing aggregate pushdown paths References: <5BFD3EAD.2060301@lab.ntt.co.jp> <5BFE1BDE.7010306@lab.ntt.co.jp> <5C010821.7050102@lab.ntt.co.jp> <5C051180.7090804@lab.ntt.co.jp> <5C0639B7.1080006@lab.ntt.co.jp> <5C25DE9B.5010000@lab.ntt.co.jp> <5C2F449C.7010103@lab.ntt.co.jp> <5C485173.5040503@lab.ntt.co.jp> In-Reply-To: <5C485173.5040503@lab.ntt.co.jp> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Pg Hackers X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk (2019/01/23 20:35), Etsuro Fujita wrote: > Attached is an updated version of the patch. > > Changes: > * Fixed a stupid bug in the case when use_remote_estimate > * Fixed a typo in a comment I added > * Modified comments I added a little bit further > * Added the commit message > > If there are no objections, I'll push that. Pushed after fixing another typo in a comment. Best regards, Etsuro Fujita