Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzfMt-0004Ix-Fb for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Mar 2019 10:26:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gzfMs-0005S1-5N for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Mar 2019 10:26:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzfMr-0005Rq-Ul for pgsql-hackers@lists.postgresql.org; Fri, 01 Mar 2019 10:26:13 +0000 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gzfMp-0000Sz-8B for pgsql-hackers@postgresql.org; Fri, 01 Mar 2019 10:26:13 +0000 Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x21AQ93C029843; Fri, 1 Mar 2019 19:26:09 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id EA7D7EA833D; Fri, 1 Mar 2019 19:26:08 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id DFD5EEA80FA; Fri, 1 Mar 2019 19:26:08 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.75]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id D0FF2400342; Fri, 1 Mar 2019 19:26:08 +0900 (JST) Message-ID: <5C7908B9.5070407@lab.ntt.co.jp> Date: Fri, 01 Mar 2019 19:26:01 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 Subject: Re: Oddity with parallel safety test for scan/join target in grouping_planner References: <5C75303E.8020303@lab.ntt.co.jp> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Robert Haas Cc: Pg Hackers X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk (2019/02/28 0:52), Robert Haas wrote: > On Tue, Feb 26, 2019 at 7:26 AM Etsuro Fujita > wrote: >> The parallel safety of the final scan/join target is determined from the >> grouping target, not that target, which [ is wrong ] > Your patch looks right to me. I think it would be better for you to take this one. Could you? Best regards, Etsuro Fujita