Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3c5O-0001uV-F0 for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Mar 2019 07:44:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h3c5N-0007Go-4U for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Mar 2019 07:44:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3c5M-0007Gb-T3 for pgsql-hackers@lists.postgresql.org; Tue, 12 Mar 2019 07:44:28 +0000 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h3c5J-00057a-OI for pgsql-hackers@postgresql.org; Tue, 12 Mar 2019 07:44:28 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x2C7iLIx002084; Tue, 12 Mar 2019 16:44:21 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id BF9C6639B20; Tue, 12 Mar 2019 16:44:21 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id B47A7639B1D; Tue, 12 Mar 2019 16:44:21 +0900 (JST) Received: from [IPv6:::1] (unknown [129.60.241.75]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id ACF994002A9; Tue, 12 Mar 2019 16:44:21 +0900 (JST) Message-ID: <5C876354.1000905@lab.ntt.co.jp> Date: Tue, 12 Mar 2019 16:44:20 +0900 From: Etsuro Fujita User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 Subject: Re: Oddity with parallel safety test for scan/join target in grouping_planner References: <5C75303E.8020303@lab.ntt.co.jp> <5C7908B9.5070407@lab.ntt.co.jp> <24818.1552077419@sss.pgh.pa.us> <5C85DC65.2050409@lab.ntt.co.jp> <32401.1552277190@sss.pgh.pa.us> <5C85ED63.8000805@lab.ntt.co.jp> <1962.1552281261@sss.pgh.pa.us> <5C85F24E.4050404@lab.ntt.co.jp> <22068.1552315572@sss.pgh.pa.us> In-Reply-To: <22068.1552315572@sss.pgh.pa.us> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Tom Lane Cc: Robert Haas , Pg Hackers X-TM-AS-MML: disable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk (2019/03/11 23:46), Tom Lane wrote: > So this is > just a plan-quality problem not a wrong-answer problem. > > However, I'd still argue for back-patching into v11, on the grounds > that this is a regression from v10. The example you just gave does > produce the desired plan in v10, and I think it's more likely that > people would complain about a regression from v10 than that they'd > be unhappy because we changed it between 11.2 and 11.3. Agreed. I committed the patch to v11 and HEAD. Thanks for reviewing! Best regards, Etsuro Fujita