Subject: Re: The two "XML Fixes" patches still in need of review
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <5C81F8C0.6090901@anastigmatix.net>
 <12427.1553375114@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Markus Winand <markus.winand@winand.at>,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
 Michael Paquier <michael@paquier.xyz>,
 Pavel Stehule <pavel.stehule@gmail.com>
From: Chapman Flack <chap@anastigmatix.net>
Message-ID: <5C96B141.5050802@anastigmatix.net>
Date: Sat, 23 Mar 2019 18:20:49 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <12427.1553375114@sss.pgh.pa.us>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/23/19 17:05, Tom Lane wrote:

> Just to update this thread --- per the other thread at
> https://postgr.es/m/CAN-V+g-6JqUQEQZ55Q3toXEN6d5Ez5uvzL4VR+8KtvJKj31taw@mail.gmail.com
> I've now pushed a somewhat-adjusted version of the XML-content fix
> patch.  The documentation patch needs some small rebasing to apply
> after that one instead of before it.

Will do.

> Perhaps it'd make sense under the XML section in datatype.sgml,
> but I think I might lean to making it a new section in Appendix D
> (SQL Conformance).

Sounds like the option (4) I proposed back in [1]. I suppose it won't
be much trouble to move.

> I'm not going to touch the documentation patch myself; I don't know
> enough about XML to review it competently.

I would be happy even to see it reviewed for style, and if anybody's
willing to look at the technical content even if not feeling ideally
prepared, I'd be happy to respond or give references for any points
in question.

It does fix a number of actual bugs in the existing documentation, so
while it would be ideal to apply a higher standard of technical review
to this patch, it'd be less ideal to have existing buggy doc lingering on
because nobody feels up to reviewing at that ideal higher standard.

Regards,
-Chap

[1] https://www.postgresql.org/message-id/5C298BCB.4060704%40anastigmatix.net