Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\))
Subject: Re: index_delete_sort: Unnecessary variable "low" is used in heapam.c
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <8aeb7b3eda53ca4c65fbacf8f43628fb@oss.nttdata.com>
Date: Tue, 24 Sep 2024 14:31:30 +0200
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
 Peter Geoghegan <pg@bowt.ie>
Content-Transfer-Encoding: quoted-printable
Message-Id: <5DCA3F10-18DF-4824-8557-7F6C9295810E@yesql.se>
References: <8aeb7b3eda53ca4c65fbacf8f43628fb@oss.nttdata.com>
To: btnakamurakoukil <btnakamurakoukil@oss.nttdata.com>
Archived-At: <https://www.postgresql.org/message-id/5DCA3F10-18DF-4824-8557-7F6C9295810E%40yesql.se>
Precedence: bulk

> On 24 Sep 2024, at 10:32, btnakamurakoukil =
<btnakamurakoukil@oss.nttdata.com> wrote:

> I noticed unnecessary variable "low" in index_delete_sort() =
(/postgres/src/backend/access/heap/heapam.c), patch attached. What do =
you think?

That variable does indeed seem to not be used, and hasn't been used =
since it
was committed in d168b666823.  The question is if it's a left-over from
development which can be removed, or if it should be set and we're =
missing an
optimization.  Having not read the referenced paper I can't tell so =
adding
Peter Geoghegan who wrote this for clarification.

--
Daniel Gustafsson