Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: pgindent versus struct members and typedefs
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <509793.1764715875@sss.pgh.pa.us>
Date: Wed, 3 Dec 2025 07:06:45 +0800
Cc: Nathan Bossart <nathandbossart@gmail.com>,
 Rahila Syed <rahilasyed90@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <5E70CB69-1E2D-471B-8CF8-83205E5E14CE@gmail.com>
References: <aS9hkwnkWf3dZIA_@nathan>
 <347EA055-D626-414C-B10D-7E70041B9B55@gmail.com>
 <509793.1764715875@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/5E70CB69-1E2D-471B-8CF8-83205E5E14CE%40gmail.com>
Precedence: bulk


> On Dec 3, 2025, at 06:51, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> Chao Li <li.evan.chao@gmail.com> writes:
>> On Dec 3, 2025, at 06:00, Nathan Bossart <nathandbossart@gmail.com> =
wrote:
>>> I tried to fix pgindent for a few, but the code is basically =
impenetrable.
>>> I didn't find any fixes upstream [0], either.  As noted above, we =
could
>>> also fix it by avoiding the naming conflicts.  However, I can't =
imagine
>>> that's worth the churn, and I've already spent way too much time on =
this,
>>> so IMHO the best thing to do here is nothing.
>=20
>> I think that=E2=80=99s fine.
>=20
> Agreed, not worth the trouble to fool with.
>=20
>> Actually I see the other problem with pgindent, where if a =E2=80=9Cels=
e=E2=80=9D clause contains a multiple-line comment and a single =
statement without braces, for example:
>> ...
>> I tried to fix but failed. For that problem, a solution is to add =
braces to the =E2=80=9Celse=E2=80=9D clause.
>=20
> In this case, I think pgindent is indirectly enforcing good style.
> I do not like omitting braces around anything that's more than one
> line; readers have to pay close attention to whether the code is
> doing what it was intended to.
>=20

For =E2=80=9Cone line=E2=80=9D, do you mean only a single line of =
statement or one line statement plus one line comment?

To clarify the pgindnet problem, if we have a one-line comment plus =
one-line statement, for example:
```
    else
          /* one line comment */
          printf(=E2=80=A6);
```

In this case, pgindent will not add an empty line after =E2=80=9Celse=E2=80=
=9D.

But I totally agree with you, when there is a multiple-line comment and =
a single statement, it's a good habit to add braces.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/