Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puXIR-0000oS-Jt for pgsql-hackers@arkaria.postgresql.org; Thu, 04 May 2023 11:38:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1puXIP-0006uX-Uk for pgsql-hackers@arkaria.postgresql.org; Thu, 04 May 2023 11:38:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puXIP-0006uO-H2 for pgsql-hackers@lists.postgresql.org; Thu, 04 May 2023 11:38:49 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1puXIL-000TZo-U3 for pgsql-hackers@lists.postgresql.org; Thu, 04 May 2023 11:38:48 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 794C02F51302 for ; Thu, 4 May 2023 13:38:27 +0200 (CEST) Received: from s981.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 6A0C22E289F9 for ; Thu, 4 May 2023 13:38:27 +0200 (CEST) Received: from s476.loopia.se (unknown [172.22.191.6]) by s981.loopia.se (Postfix) with ESMTP id 68A7222B179D for ; Thu, 4 May 2023 13:38:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s934.loopia.se ([172.22.191.5]) by s476.loopia.se (s476.loopia.se [172.22.190.16]) (amavisd-new, port 10024) with LMTP id FcmFd6BBTzL9 for ; Thu, 4 May 2023 13:38:27 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s934.loopia.se (Postfix) with ESMTPSA id E80FE7CEA53 for ; Thu, 4 May 2023 13:38:26 +0200 (CEST) From: Daniel Gustafsson Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\)) Subject: evtcache: EventTriggerCache vs Event Trigger Cache Message-Id: <5EDC969E-CAE3-4CBD-965E-3B8A1294CFA4@yesql.se> Date: Thu, 4 May 2023 13:38:26 +0200 To: PostgreSQL Hackers X-Mailer: Apple Mail (2.3696.120.41.1.2) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk When reading a memory contexts log I realized that we have this: LOG: level: 2; EventTriggerCache: 8192 total in 1 blocks; 7928 free (4 = chunks); 264 used LOG: level: 3; Event Trigger Cache: 8192 total in 1 blocks; 2616 free = (0 chunks); 5576 used The reason is that BuildEventTriggerCache sets up a context = "EventTriggerCache" which house a hash named "Event Trigger Cache" which in turn creates a = context with the table name. I think it makes sense that these share the same = name, but I think it would be less confusing if they also shared the same = spelling whitespace-wise. Any reason to not rename the hash EventTriggerCache to = make the logging a tiny bit easier to read and grep? -- Daniel Gustafsson