Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\))
Subject: Re: CREATE INDEX CONCURRENTLY on partitioned index
From: Ilya Gladyshev <ilya.v.gladyshev@gmail.com>
In-Reply-To: <Zo_QneIgShh7zrKn@pryzbyj2023>
Date: Thu, 11 Jul 2024 21:35:24 +0100
Cc: Alexander Pyhalov <a.pyhalov@postgrespro.ru>,
 pgsql-hackers@lists.postgresql.org,
 Masahiko Sawada <sawada.mshk@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
 =?utf-8?B?IuadjuadsCjmhY7ov70pIg==?= <adger.lj@alibaba-inc.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <5F602655-58E6-4562-85D3-34E04BE9D60C@gmail.com>
References: <ZCBb7flZBr4wtKlK@telsasoft.com>
 <acd31119ede945f8092ba4faac5e1fb6@postgrespro.ru>
 <ZK9hLNhTMXFcAcRG@telsasoft.com>
 <37d3f0a984a15f6465b83027eed8c588@postgrespro.ru>
 <efd4febd4ed08e579318de59e16e087c@postgrespro.ru>
 <8fe0027c-a4f9-43a0-afc1-20362c159d07@gmail.com>
 <a86b4d57f83c85519cc25431e9249f28@postgrespro.ru>
 <76a11eea-c5ae-4034-971d-c8a2df0bb14d@gmail.com>
 <df5e91946320d4c3aade07898d4ba728@postgrespro.ru>
 <55cfae76-2ffa-43ed-a7e7-901bffbebee4@gmail.com>
 <Zo_QneIgShh7zrKn@pryzbyj2023>
To: Justin Pryzby <pryzby@telsasoft.com>
Archived-At: <https://www.postgresql.org/message-id/5F602655-58E6-4562-85D3-34E04BE9D60C%40gmail.com>
Precedence: bulk

It is broken in master, I just didn=E2=80=99t want to create a separate =
thread, but it can be fixed independently. As I remember, the problem is =
that progress is tracked for each table in the hierarchy as if the table =
is processed separately, without ever setting partitions_total and =
partitions_done counters.

> 11 =D0=B8=D1=8E=D0=BB=D1=8F 2024=E2=80=AF=D0=B3., =D0=B2 13:31, Justin =
Pryzby <pryzby@telsasoft.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=
=B0):
>=20
> On Sat, Jun 15, 2024 at 07:56:38PM +0100, Ilya Gladyshev wrote:
>> In addition, I noticed that progress tracking is once again broken =
for
>> partitioned tables, while looking at REINDEX implementation, =
attaching the
>> second patch to fix it.
>=20
> Thanks for the fixes, I started reviewing them but need some more time
> to digest.
>=20
> Do you mean that progress reporting is broken in master, for REINDEX, =
or
> just with this patch ?
>=20
> --=20
> Justin