Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uHdta-006Vc0-MF for pgsql-hackers@arkaria.postgresql.org; Wed, 21 May 2025 07:29:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uHdtZ-0049LR-Co for pgsql-hackers@arkaria.postgresql.org; Wed, 21 May 2025 07:29:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uHdtZ-0049LI-3s for pgsql-hackers@lists.postgresql.org; Wed, 21 May 2025 07:29:44 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uHdtW-0005iA-0r for pgsql-hackers@lists.postgresql.org; Wed, 21 May 2025 07:29:44 +0000 Received: from [192.168.11.9] (p1696134-ipoe.ipoe.ocn.ne.jp [118.0.93.133]) by oss.nttdata.com (Postfix) with ESMTPSA id 5F90A6096B; Wed, 21 May 2025 16:29:37 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com Message-ID: <5a01bf06-d3d2-49f5-bc94-0a1b6990320f@oss.nttdata.com> Date: Wed, 21 May 2025 16:29:36 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Document default values for pgoutput options + fix missing initialization for "origin" Content-Language: en-US To: Amit Kapila , Euler Taveira Cc: pgsql-hackers@lists.postgresql.org References: <8d21fb98-5c25-4dee-8387-e5a62b01ea7d@app.fastmail.com> From: Fujii Masao In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025/05/20 13:09, Amit Kapila wrote: >> + Option to enable streaming of in-progress transactions. Valid values are >> + off (the default), on and >> + parallel. The setting parallel >> + enables sending extra information with some messages to be used for >> + parallelization. Minimum protocol version 2 is required to turn it >> + on. Minimum protocol version 4 is required for the >> + parallel value. >> > > One point to note about this is that we change the default value for > the streaming option to parallel for a subscription in the commit > 1bf1140be8. But pgoutput still considers the default value to be off. > I thought about this, but not sure if there is any clear value in > changing the default of pgoutput. Would you have any thoughts on the > same? Using "off" as the pgoutput's default seems better to me, since it works regardless of protocol version. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION