Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAq3q-008PRg-63 for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Dec 2023 11:27:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rAq3o-008yv2-Px for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Dec 2023 11:27:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAq3o-008yuu-Er for pgsql-hackers@lists.postgresql.org; Wed, 06 Dec 2023 11:27:24 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAq3l-00ANUV-Mq for pgsql-hackers@lists.postgresql.org; Wed, 06 Dec 2023 11:27:23 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 635AF5C02A5; Wed, 6 Dec 2023 06:27:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 06 Dec 2023 06:27:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1701862039; x=1701948439; bh=yN 3f4eIjQqLgfbVlgJ8V4FqWQSRnLBfWgCFI7BgEZo4=; b=iUSNuPIXIP7E2YF6Di r6JN0QsVzUQNnxgMWiQiGAbrqhWq+EP0eGShYfEfJPAUz1xJsaU5UVK2ybnjUuTM +JcILg+pXfW2VxNArl48HCGo2c300l+0JKw69Nr8uB5HSw5bi8R3/NTEIH17oUsP vBodY3GE4AQOs4GFfSwjWJjQcXiqEi39/hspDTM29wrFmCpCwBQ8f85vIwsQ+tYI 26TDMNMBjzd40sl4H//bBReq5zTPfTAbhCtzNKXW51FO0SBGY7XxGoxuCRKeDeK5 bjJTwa77c2M6BzYVdc06/ky7ZdWx6+PDaZ0/OuZ09pHOq/rh8noFdiMIpRIbQKTX Pujw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701862039; x=1701948439; bh=yN3f4eIjQqLgf bVlgJ8V4FqWQSRnLBfWgCFI7BgEZo4=; b=gIWOWGXt0uh1Z7qXDFwg5NoieLvvw lZbFOvpT93W9HtPWQgFeKtDEQIY8IjU2xsAoHnsxD1lFzilo1fS3N7OwJzrDL4MC MRBjq/O2e59UBJoucWtnJgUgzfYPkloZVqWV+k/MxzEKrZ8MzuRjBLMr2CwjFSJY 5UKb4796+CFfOrvmpwXiX+uAb0CVfaKnEPan7D+MnOSPH0Ax/X4vdrtlo0AKwrJt 1wfJKZ7qms5h2WXriiybbylhUgnEqRjhQCz9lMqVg8tUVhn+O/lD3e1TsoGoi2St UrJfVxena6jrOUGGsuttc4ZD0Ix3iaOe+RxRw7OS5DBl2/ZSTBGO3HE6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudektddgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfhfhfgjsehmtderredtvdejnecuhfhrohhmpefrvghtvghr ucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgheqne cuggftrfgrthhtvghrnhepfffgvdfgfeegleegvdeileevudejgfegtefhteektefhkedt heffudehkedtlefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Dec 2023 06:27:18 -0500 (EST) Content-Type: multipart/mixed; boundary="------------dCLzV1YERLB7LTHnhCVttJpC" Message-ID: <5a2e43da-0425-4fc1-9b13-19fd33123950@eisentraut.org> Date: Wed, 6 Dec 2023 12:27:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Is WAL_DEBUG related code still relevant today? Content-Language: en-US To: Bharath Rupireddy , PostgreSQL Hackers References: From: Peter Eisentraut In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------dCLzV1YERLB7LTHnhCVttJpC Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02.12.23 15:06, Bharath Rupireddy wrote: > I enabled this code by compiling with the WAL_DEBUG macro and setting > wal_debug GUC to on. Firstly, the compilation on Windows failed > because XL_ROUTINE was passed inappropriately for XLogReaderAllocate() > used. This kind of thing could be mostly avoided if we didn't hide all the WAL_DEBUG behind #ifdefs. For example, in the attached patch, I instead changed it so that if (XLOG_DEBUG) resolves to if (false) in the normal case. That way, we don't need to wrap that in #ifdef WAL_DEBUG, and the compiler can see the disabled code and make sure it continues to build. --------------dCLzV1YERLB7LTHnhCVttJpC Content-Type: text/plain; charset=UTF-8; name="0001-Make-WAL_DEBUG-code-harder-to-break-accidentally.patch" Content-Disposition: attachment; filename*0="0001-Make-WAL_DEBUG-code-harder-to-break-accidentally.patch" Content-Transfer-Encoding: base64 RnJvbSA5M2M3NDQ2MmMzZTI1M2YzY2U5ZmQxYmViYTFmMDkyOTA5ODhkZThjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogV2VkLCA2IERlYyAyMDIzIDEyOjIyOjM4ICswMTAwClN1YmplY3Q6 IFtQQVRDSF0gTWFrZSBXQUxfREVCVUcgY29kZSBoYXJkZXIgdG8gYnJlYWsgYWNjaWRlbnRh bGx5CgotLS0KIHNyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL2dlbmVyaWNfeGxvZy5jIHwg IDIgLS0KIHNyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2cuYyAgICAgICAgIHwgMTAg LS0tLS0tLS0tLQogc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZ3JlY292ZXJ5LmMg fCAgNyAtLS0tLS0tCiBzcmMvaW5jbHVkZS9hY2Nlc3MveGxvZy5oICAgICAgICAgICAgICAg ICB8ICAyICsrCiA0IGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0vZ2VuZXJp Y194bG9nLmMgYi9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS9nZW5lcmljX3hsb2cuYwpp bmRleCBhYmQ5ZTFjNzQ5Li41YjkxMGYxMDI0IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9h Y2Nlc3MvdHJhbnNhbS9nZW5lcmljX3hsb2cuYworKysgYi9zcmMvYmFja2VuZC9hY2Nlc3Mv dHJhbnNhbS9nZW5lcmljX3hsb2cuYwpAQCAtMjQ4LDcgKzI0OCw2IEBAIGNvbXB1dGVEZWx0 YShQYWdlRGF0YSAqcGFnZURhdGEsIFBhZ2UgY3VycGFnZSwgUGFnZSB0YXJnZXRwYWdlKQog CSAqIElmIHhsb2cgZGVidWcgaXMgZW5hYmxlZCwgdGhlbiBjaGVjayBwcm9kdWNlZCBkZWx0 YS4gIFJlc3VsdCBvZiBkZWx0YQogCSAqIGFwcGxpY2F0aW9uIHRvIGN1cnBhZ2Ugc2hvdWxk IGJlIGVxdWl2YWxlbnQgdG8gdGFyZ2V0cGFnZS4KIAkgKi8KLSNpZmRlZiBXQUxfREVCVUcK IAlpZiAoWExPR19ERUJVRykKIAl7CiAJCVBHQWxpZ25lZEJsb2NrIHRtcDsKQEAgLTI2MCw3 ICsyNTksNiBAQCBjb21wdXRlRGVsdGEoUGFnZURhdGEgKnBhZ2VEYXRhLCBQYWdlIGN1cnBh Z2UsIFBhZ2UgdGFyZ2V0cGFnZSkKIAkJCQkgICBCTENLU1ogLSB0YXJnZXRVcHBlcikgIT0g MCkKIAkJCWVsb2coRVJST1IsICJyZXN1bHQgb2YgZ2VuZXJpYyB4bG9nIGFwcGx5IGRvZXMg bm90IG1hdGNoIik7CiAJfQotI2VuZGlmCiB9CiAKIC8qCmRpZmYgLS1naXQgYS9zcmMvYmFj a2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9nLmMgYi9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNh bS94bG9nLmMKaW5kZXggMmQ2MDNkOGRlZS4uM2E3YTM4YTEwMCAxMDA2NDQKLS0tIGEvc3Jj L2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZy5jCisrKyBiL3NyYy9iYWNrZW5kL2FjY2Vz cy90cmFuc2FtL3hsb2cuYwpAQCAtNjQ0LDkgKzY0NCw3IEBAIHN0YXRpYyBib29sIHVwZGF0 ZU1pblJlY292ZXJ5UG9pbnQgPSB0cnVlOwogc3RhdGljIGludAlNeUxvY2tObyA9IDA7CiBz dGF0aWMgYm9vbCBob2xkaW5nQWxsTG9ja3MgPSBmYWxzZTsKIAotI2lmZGVmIFdBTF9ERUJV Rwogc3RhdGljIE1lbW9yeUNvbnRleHQgd2FsRGVidWdDeHQgPSBOVUxMOwotI2VuZGlmCiAK IHN0YXRpYyB2b2lkIENsZWFudXBBZnRlckFyY2hpdmVSZWNvdmVyeShUaW1lTGluZUlEIEVu ZE9mTG9nVExJLAogCQkJCQkJCQkJCVhMb2dSZWNQdHIgRW5kT2ZMb2csCkBAIC05OTcsNyAr OTk1LDYgQEAgWExvZ0luc2VydFJlY29yZChYTG9nUmVjRGF0YSAqcmRhdGEsCiAJCX0KIAl9 CiAKLSNpZmRlZiBXQUxfREVCVUcKIAlpZiAoWExPR19ERUJVRykKIAl7CiAJCXN0YXRpYyBY TG9nUmVhZGVyU3RhdGUgKmRlYnVnX3JlYWRlciA9IE5VTEw7CkBAIC0xMDYxLDcgKzEwNTgs NiBAQCBYTG9nSW5zZXJ0UmVjb3JkKFhMb2dSZWNEYXRhICpyZGF0YSwKIAkJcGZyZWUocmVj b3JkQnVmLmRhdGEpOwogCQlNZW1vcnlDb250ZXh0U3dpdGNoVG8ob2xkQ3h0KTsKIAl9Ci0j ZW5kaWYKIAogCS8qCiAJICogVXBkYXRlIG91ciBnbG9iYWwgdmFyaWFibGVzCkBAIC0xOTk3 LDEzICsxOTkzLDExIEBAIEFkdmFuY2VYTEluc2VydEJ1ZmZlcihYTG9nUmVjUHRyIHVwdG8s IFRpbWVMaW5lSUQgdGxpLCBib29sIG9wcG9ydHVuaXN0aWMpCiAJfQogCUxXTG9ja1JlbGVh c2UoV0FMQnVmTWFwcGluZ0xvY2spOwogCi0jaWZkZWYgV0FMX0RFQlVHCiAJaWYgKFhMT0df REVCVUcgJiYgbnBhZ2VzID4gMCkKIAl7CiAJCWVsb2coREVCVUcxLCAiaW5pdGlhbGl6ZWQg JWQgcGFnZXMsIHVwIHRvICVYLyVYIiwKIAkJCSBucGFnZXMsIExTTl9GT1JNQVRfQVJHUyhO ZXdQYWdlRW5kUHRyKSk7CiAJfQotI2VuZGlmCiB9CiAKIC8qCkBAIC0yNjQxLDEzICsyNjM1 LDExIEBAIFhMb2dGbHVzaChYTG9nUmVjUHRyIHJlY29yZCkKIAlpZiAocmVjb3JkIDw9IExv Z3dydFJlc3VsdC5GbHVzaCkKIAkJcmV0dXJuOwogCi0jaWZkZWYgV0FMX0RFQlVHCiAJaWYg KFhMT0dfREVCVUcpCiAJCWVsb2coTE9HLCAieGxvZyBmbHVzaCByZXF1ZXN0ICVYLyVYOyB3 cml0ZSAlWC8lWDsgZmx1c2ggJVgvJVgiLAogCQkJIExTTl9GT1JNQVRfQVJHUyhyZWNvcmQp LAogCQkJIExTTl9GT1JNQVRfQVJHUyhMb2d3cnRSZXN1bHQuV3JpdGUpLAogCQkJIExTTl9G T1JNQVRfQVJHUyhMb2d3cnRSZXN1bHQuRmx1c2gpKTsKLSNlbmRpZgogCiAJU1RBUlRfQ1JJ VF9TRUNUSU9OKCk7CiAKQEAgLTI5MDMsMTQgKzI4OTUsMTIgQEAgWExvZ0JhY2tncm91bmRG bHVzaCh2b2lkKQogCQlXcml0ZVJxc3QuRmx1c2ggPSAwOwogCX0KIAotI2lmZGVmIFdBTF9E RUJVRwogCWlmIChYTE9HX0RFQlVHKQogCQllbG9nKExPRywgInhsb2cgYmcgZmx1c2ggcmVx dWVzdCB3cml0ZSAlWC8lWDsgZmx1c2g6ICVYLyVYLCBjdXJyZW50IGlzIHdyaXRlICVYLyVY OyBmbHVzaCAlWC8lWCIsCiAJCQkgTFNOX0ZPUk1BVF9BUkdTKFdyaXRlUnFzdC5Xcml0ZSks CiAJCQkgTFNOX0ZPUk1BVF9BUkdTKFdyaXRlUnFzdC5GbHVzaCksCiAJCQkgTFNOX0ZPUk1B VF9BUkdTKExvZ3dydFJlc3VsdC5Xcml0ZSksCiAJCQkgTFNOX0ZPUk1BVF9BUkdTKExvZ3dy dFJlc3VsdC5GbHVzaCkpOwotI2VuZGlmCiAKIAlTVEFSVF9DUklUX1NFQ1RJT04oKTsKIApk aWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZ3JlY292ZXJ5LmMg Yi9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94bG9ncmVjb3ZlcnkuYwppbmRleCBjNjE1 NjY2NjZhLi4yNmJhOTkwYjcxIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9hY2Nlc3MvdHJh bnNhbS94bG9ncmVjb3ZlcnkuYworKysgYi9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94 bG9ncmVjb3ZlcnkuYwpAQCAtMzk2LDkgKzM5Niw3IEBAIHN0YXRpYyBib29sIHJlYWRfdGFi bGVzcGFjZV9tYXAoTGlzdCAqKnRhYmxlc3BhY2VzKTsKIHN0YXRpYyB2b2lkIHhsb2dyZWNv dmVyeV9yZWRvKFhMb2dSZWFkZXJTdGF0ZSAqcmVjb3JkLCBUaW1lTGluZUlEIHJlcGxheVRM SSk7CiBzdGF0aWMgdm9pZCBDaGVja1JlY292ZXJ5Q29uc2lzdGVuY3kodm9pZCk7CiBzdGF0 aWMgdm9pZCBybV9yZWRvX2Vycm9yX2NhbGxiYWNrKHZvaWQgKmFyZyk7Ci0jaWZkZWYgV0FM X0RFQlVHCiBzdGF0aWMgdm9pZCB4bG9nX291dHJlYyhTdHJpbmdJbmZvIGJ1ZiwgWExvZ1Jl YWRlclN0YXRlICpyZWNvcmQpOwotI2VuZGlmCiBzdGF0aWMgdm9pZCB4bG9nX2Jsb2NrX2lu Zm8oU3RyaW5nSW5mbyBidWYsIFhMb2dSZWFkZXJTdGF0ZSAqcmVjb3JkKTsKIHN0YXRpYyB2 b2lkIGNoZWNrVGltZUxpbmVTd2l0Y2goWExvZ1JlY1B0ciBsc24sIFRpbWVMaW5lSUQgbmV3 VExJLAogCQkJCQkJCQlUaW1lTGluZUlEIHByZXZUTEksIFRpbWVMaW5lSUQgcmVwbGF5VExJ KTsKQEAgLTE3MDMsNyArMTcwMSw2IEBAIFBlcmZvcm1XYWxSZWNvdmVyeSh2b2lkKQogCQkJ CWVyZXBvcnRfc3RhcnR1cF9wcm9ncmVzcygicmVkbyBpbiBwcm9ncmVzcywgZWxhcHNlZCB0 aW1lOiAlbGQuJTAyZCBzLCBjdXJyZW50IExTTjogJVgvJVgiLAogCQkJCQkJCQkJCSBMU05f Rk9STUFUX0FSR1MoeGxvZ3JlYWRlci0+UmVhZFJlY1B0cikpOwogCi0jaWZkZWYgV0FMX0RF QlVHCiAJCQlpZiAoWExPR19ERUJVRyB8fAogCQkJCShyZWNvcmQtPnhsX3JtaWQgPT0gUk1f WEFDVF9JRCAmJiB0cmFjZV9yZWNvdmVyeV9tZXNzYWdlcyA8PSBERUJVRzIpIHx8CiAJCQkJ KHJlY29yZC0+eGxfcm1pZCAhPSBSTV9YQUNUX0lEICYmIHRyYWNlX3JlY292ZXJ5X21lc3Nh Z2VzIDw9IERFQlVHMykpCkBAIC0xNzIwLDcgKzE3MTcsNiBAQCBQZXJmb3JtV2FsUmVjb3Zl cnkodm9pZCkKIAkJCQllbG9nKExPRywgIiVzIiwgYnVmLmRhdGEpOwogCQkJCXBmcmVlKGJ1 Zi5kYXRhKTsKIAkJCX0KLSNlbmRpZgogCiAJCQkvKiBIYW5kbGUgaW50ZXJydXB0IHNpZ25h bHMgb2Ygc3RhcnR1cCBwcm9jZXNzICovCiAJCQlIYW5kbGVTdGFydHVwUHJvY0ludGVycnVw dHMoKTsKQEAgLTIyNTYsOCArMjI1Miw2IEBAIHhsb2dfb3V0ZGVzYyhTdHJpbmdJbmZvIGJ1 ZiwgWExvZ1JlYWRlclN0YXRlICpyZWNvcmQpCiAJcm1nci5ybV9kZXNjKGJ1ZiwgcmVjb3Jk KTsKIH0KIAotI2lmZGVmIFdBTF9ERUJVRwotCiBzdGF0aWMgdm9pZAogeGxvZ19vdXRyZWMo U3RyaW5nSW5mbyBidWYsIFhMb2dSZWFkZXJTdGF0ZSAqcmVjb3JkKQogewpAQCAtMjI3MCw3 ICsyMjY0LDYgQEAgeGxvZ19vdXRyZWMoU3RyaW5nSW5mbyBidWYsIFhMb2dSZWFkZXJTdGF0 ZSAqcmVjb3JkKQogCiAJeGxvZ19ibG9ja19pbmZvKGJ1ZiwgcmVjb3JkKTsKIH0KLSNlbmRp ZgkJCQkJCQkvKiBXQUxfREVCVUcgKi8KIAogLyoKICAqIFJldHVybnMgYSBzdHJpbmcgZ2l2 aW5nIGluZm9ybWF0aW9uIGFib3V0IGFsbCB0aGUgYmxvY2tzIGluIGFuCmRpZmYgLS1naXQg YS9zcmMvaW5jbHVkZS9hY2Nlc3MveGxvZy5oIGIvc3JjL2luY2x1ZGUvYWNjZXNzL3hsb2cu aAppbmRleCBhMTQxMjZkMTY0Li42OThkZDc5YzJkIDEwMDY0NAotLS0gYS9zcmMvaW5jbHVk ZS9hY2Nlc3MveGxvZy5oCisrKyBiL3NyYy9pbmNsdWRlL2FjY2Vzcy94bG9nLmgKQEAgLTEy NSw2ICsxMjUsOCBAQCBleHRlcm4gUEdETExJTVBPUlQgaW50IHdhbF9sZXZlbDsKIAogI2lm ZGVmIFdBTF9ERUJVRwogZXh0ZXJuIFBHRExMSU1QT1JUIGJvb2wgWExPR19ERUJVRzsKKyNl bHNlCisjZGVmaW5lIFhMT0dfREVCVUcgZmFsc2UKICNlbmRpZgogCiAvKgotLSAKMi40My4w Cgo= --------------dCLzV1YERLB7LTHnhCVttJpC--