Message-ID: <5a88920da32b910fac64608980d8fe690a14d7d7.camel@cybertec.at>
Subject: Re: JIT works only partially with meson build?
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Yugo Nagata <nagata@sraoss.co.jp>
Cc: David Rowley <dgrowleyml@gmail.com>, Pgsql Hackers
	 <pgsql-hackers@postgresql.org>
Date: Wed, 01 Oct 2025 15:25:51 +0200
In-Reply-To: <20250930223119.066336beb38fc93392442c20@sraoss.co.jp>
References: <20250526150820.28ea70625645e0d6d12be7d5@sraoss.co.jp>
		<CAApHDvpGYzFows6Yc2j1XUEP-rFegMwA1tMkw-_DSuk0Opo7zw@mail.gmail.com>
		<20250627161959.217df60b49a460e837275e51@sraoss.co.jp>
		<09d61e56103fa319dbaf21fb3156ab9f16dbe25b.camel@cybertec.at>
	 <20250930223119.066336beb38fc93392442c20@sraoss.co.jp>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/5a88920da32b910fac64608980d8fe690a14d7d7.camel%40cybertec.at>
Precedence: bulk

On Tue, 2025-09-30 at 22:31 +0900, Yugo Nagata wrote:
> > You used the <option> tag, which I believe is correct, but the surround=
ing
> > code uses <literal>.  I don't think it renders differently, but I think=
 it
> > would be good to use the same tag.  I suggest that you change the
> > surrounding code to use <option> as well.
>=20
> Agreed. I fixed it to use <option>, as well as in other place where I thi=
nk
> <option> is appropriate. Please find the attached patch.

I'll mark it "eeady for committer".  A committer can decide whether to appl=
y
this to HEAD or not.  I probably would, and revert it if PostgreSQL + Meson=
 +
Windows learns to produce bitcode.

Yours,
Laurenz Albe