From: Yury Zhuravlev <u.zhuravlev@postgrespro.ru>
To: <pgsql-hackers@postgresql.org>
Cc: Michael Paquier <michael.paquier@gmail.com>
Subject: Re: WIP: About CMake v2
Date: Fri, 16 Sep 2016 19:40:48 +0300
MIME-Version: 1.0
Message-ID: <5a8a9610-722f-49df-b609-35842fe4c8d6@postgrespro.ru>
In-Reply-To: 
 <CAB7nPqTHwOT7WfV33ywyFS6NhSEr46C+S6jWS3sR20UDN7XP0w@mail.gmail.com>
References: 
 <CAPfS4ZzwscpK2MeE73==wBOAMndW1UuvktSL6TqXAatok+WHzg@mail.gmail.com>
 <CAPfS4Zw8UReHG12RmpYYb3REqSN7Knx8coXg5_oT35HfCwggww@mail.gmail.com>
 <CAB7nPqThtTWyh4vaYSjwm=Q_nAJzVbo=_F9nkPmA68v6bD38Kw@mail.gmail.com>
 <29526280-50e2-495b-99e1-ccd4e16ffd05@postgrespro.ru>
 <CAB7nPqSWtRhZDYuFVy5jBd8AOjdNiwwM8B9fazKArZs2Hd+rWA@mail.gmail.com>
 <CAB7nPqTHwOT7WfV33ywyFS6NhSEr46C+S6jWS3sR20UDN7XP0w@mail.gmail.com>
Organization: postgrespro
User-Agent: Trojita/v0.6-216-g795fa33; Qt/5.7.0; xcb; Linux;
 Gentoo Base System release 2.3
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Michael Paquier wrote:
> Your patch recommends to build with cmake after creating build/, now I
> would expect most users to run cmake from the root folder. However
> this causes all the Makefiles to get overwritten. As supporting all
> platforms at once with cmake is going to be uncommitable, we are going
> to need both methods able to live together for a while. Well, they can
> coexist with this patch as long as cmake is not run from the root of
> the code tree, which is acceptable for me as long as the switch is not
> completed. However others may think differently on the matter.

It's really a good point. Forbidden run cmake from root it is better=20
decision for me (of course for start).=20

>Instead of getting support for all existing platforms, I would
>recommend as well focusing only on one platform for the time being,
>Linux, and get the work done correctly for that first. Once there is
>something committed, we will be able to patch the buildfarm, and get
>machines to switch to cmake one by one. After those are switched, we
>could extend that.

You mean in first version of patch I can focus on Linux systems?

>Another point of contention is support for
>extensions. How long should we keep support for the existing PGXS? How
>external extensions would compile with the new thing infrastructure?

As long as possible. I hope I can make PGXS Makefiles generator.

>Which brings me to another point, your patch is focused on features,
>meaning that per-OS checks are all grouped by feature, but it may be a
>good idea to split checks by OS if necessary, with for example
>per-platform files and scripts in cmake/os/. And we could have just
>something for Linux now.

Currently I do not have a lot OS specific tests. All checks are doing in=20
same manner.=20

>- root's .gitignore needs to add entries for CMakeFiles and
>cmake_install.cmake. You need as well to ignore CMakeCache

Thanks I done this in last commit.=20

>- A couple of headers are generated, like cubeparse.h (?)

Because BISON generate header by default. I suppose author of cube launched=
=20
bison by hand but I made it automatic.=20

>- Currently a lot of users do things like that:
>cd src/test/regress/ && make check
>But this patch breaks that, and that's not cool. Recovery tests in
>src/test/regress won't run either.

It seems restriction by design because in CMake you have only one enter=20
point.=20

>That's all I have for now. Looking forward to seeing some progress here.

I merged master to my branch and I spent time to porting all changes. I=20
hope send patch in the weekend without terrible flaws.

--=20
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


--=20
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers