Message-ID: <5abac84e-fc78-459a-a191-13efeb58c161@tantorlabs.com>
Date: Mon, 24 Feb 2025 15:27:02 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: a very significant fraction of the buildfarm is now pink
To: Jelte Fennema-Nio <postgres@jeltef.nl>,
 Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
 Andrei Lepikhov <lepihov@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <e434311c-0f84-4c2b-a10d-ecb67f1ec19d@tantorlabs.com>
 <CA+TgmobfeePej0uNfbLy0v6jUrB3D9m1Kh+QQ40_-A9KQjkqUw@mail.gmail.com>
 <f428e80d-8607-4a9d-950c-be9600f24904@gmail.com>
 <01ec86c1-e04b-4cbe-b641-22cae8b87604@tantorlabs.com>
 <CA+TgmobVWYnYDj1HZ--iqeKx+n7zTgtYCar+YfZ0V6wiX-t0Mg@mail.gmail.com>
 <73e2440e-7d8b-4860-974d-931a93326d95@gmail.com>
 <CA+TgmoYp1KvG=7L7SjiRjJrXT8kEfH10kSGp54FQd03v19OwvA@mail.gmail.com>
 <CA+Tgmoaob_3aNF5S49WFoJs6Rb37rNnd5WH_e9nXAn_jtWWCLQ@mail.gmail.com>
 <3737950.1740182671@sss.pgh.pa.us>
 <CA+TgmoZB8frH_n6tYAdFSYWUwy1wbVOzM3zHfVkHUKCj0+rHzA@mail.gmail.com>
 <h5tjttxky4wlk4easqrcaqnvly74phwttvne6crk3lm4rdjbl5@uxu33v5mxjqx>
 <CA+Tgmobec4-XiTZ0_VNf7G1znq3eJhjDL0c=3E1qkOXy4xtXxA@mail.gmail.com>
 <CAGECzQRys8t8ig7eN26rbvop+zgw06oP11L5HpYuUtA=6j_WZA@mail.gmail.com>
Content-Language: en-US
From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
In-Reply-To: <CAGECzQRys8t8ig7eN26rbvop+zgw06oP11L5HpYuUtA=6j_WZA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/5abac84e-fc78-459a-a191-13efeb58c161%40tantorlabs.com>
Precedence: bulk

Hi,

Regarding the patch push, I am not a committer, but perhaps my 
perspective might be interesting. When I noticed late on Friday evening 
that the tests had failed, I was quite anxious about the situation, 
thinking I would need to fix it right away. However, Robert committed 
the fix before that.

In general, when someone commits in any project, I believe the scale of 
the commit should be taken into account. In the case of postgres, if the 
commit changes code in critical areas like the planner, WAL, or some 
API, or involves large code changes, it’s important to be prepared to 
fix any issues that may arise. However, when changes are more minor—such 
as documentation, renaming something, or small refactors—committing late 
on a Friday may be less of a concern.

In other words, the larger the changes or the more vulnerable the areas 
of the code, the more one should be prepared for potential issues. But 
how to determine this boundary in postgres, I am not sure. I am 
confident that you will have a much better sense and experience of how 
to handle it.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.