Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p12UR-0001jS-Cm for pgsql-hackers@arkaria.postgresql.org; Fri, 02 Dec 2022 09:37:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p12UQ-0001Et-91 for pgsql-hackers@arkaria.postgresql.org; Fri, 02 Dec 2022 09:37:50 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p12UP-0001Ej-VM for pgsql-hackers@lists.postgresql.org; Fri, 02 Dec 2022 09:37:49 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1p12UN-0005lU-KX for pgsql-hackers@lists.postgresql.org; Fri, 02 Dec 2022 09:37:48 +0000 Received: by mail-wr1-x42d.google.com with SMTP id z4so6954626wrr.3 for ; Fri, 02 Dec 2022 01:37:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5xPDq+gQg6a1TfZWdEq86jNBvCwHFNqmwDpm+M5p5Ic=; b=ymgy9E5EXRtYq6wczKmvPC7BoiL/65KCrpdTwJcMlugm8ueHfEcEzQEZzeVKFxFROu GN61J69nRzPYdK83Ql42kJq8J6/TC5I5xh8qe83vUJHq8pqtoq+4Ax50209PQQdbnYkO owfPQSF33mRstVmr2S/gL9ULAX59PRkgaILzrwlu3pNL8dGzZ3jmZVp3zW3VOmIIkiYd Rtv2CjUvjEKkyZHwmhgvcYSWKEhWJYtxqzy2WakrKGWvqhLuDIfHbldLer+nitYyfM68 oGXMPkmdOiTKL924WkYhwNvycj5SBTbhIypzn+CIM+rcK/2Kgya6I5q7jIa5CWFbJltH PcOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5xPDq+gQg6a1TfZWdEq86jNBvCwHFNqmwDpm+M5p5Ic=; b=UfkzbaJaZHMfTT6U9a46g9y++laNOI+GytuJFeeBLkU04KGQnKYDSFx25k4TWBGvKl aygA0CkmRnEAG1iC65SvU8o4qiz7zT8Ex91rsnZ9H1oCswp0rRoCdDGs9aRd+0QGcxCK zazlIxPEfVZCLTv902HIC3ECETmwXyOZcq3S7jaHtSE5lcKqpfH48SVbY+g8hjAMUtIF JVFQnnG+vgjRHkz7B7Cbglb659hJN6qv4OMq1xJIavR0Ro7b8sqRfuLwa9SBegMBFowu fmpglJkB/rxvKB6+/wVmtutE/cpVih1nXsgM4YZ9WFQ8yCFfqLuXNz+Yi32Cq13xPT0J veQg== X-Gm-Message-State: ANoB5plHXA2sRiXWmSstEmTJblHozKba+21Yd5eV/A9OgFEamwLCGywy kxS/HZWFIdUru6ldkv4jch9r2g== X-Google-Smtp-Source: AA0mqf7WAB/MsXnryDJ9YxP238NVqKPg06bm7V9mNRae8/Jb2YqMReQKmO9Z6/Di7DRdAo2X+z8Mew== X-Received: by 2002:a5d:5644:0:b0:236:6db1:7cae with SMTP id j4-20020a5d5644000000b002366db17caemr43208666wrw.348.1669973866245; Fri, 02 Dec 2022 01:37:46 -0800 (PST) Received: from [192.168.1.166] ([212.228.7.114]) by smtp.gmail.com with ESMTPSA id v15-20020a5d6b0f000000b002421ed1d8c8sm6405367wrw.103.2022.12.02.01.37.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 01:37:45 -0800 (PST) Message-ID: <5abc88fd-77c1-5f61-1f7e-bd3b3d0e462e@linaro.org> Date: Fri, 2 Dec 2022 09:37:43 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] Add native windows on arm64 support Content-Language: en-US To: Michael Paquier Cc: Andres Freund , Ian Lawrence Barwick , Tom Lane , Thomas Munro , Julien Rouhaud , PostgreSQL Hackers References: <20476.1661967233@sss.pgh.pa.us> <271611.1661998926@sss.pgh.pa.us> <20221105183136.hfxyl5dclxdcoyih@awork3.anarazel.de> <7ff7c416-fdfe-517f-a65c-9e5bd8ff8cec@linaro.org> From: Niyas Sait In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 02/12/2022 05:02, Michael Paquier wrote: > Thanks for the updated version. I have been looking at it closely and > it looks like it should be able to do the job (no arm64 machine for > Windows here, sigh). > > I have one tiny comment about this part: > > - USE_ARMV8_CRC32C_WITH_RUNTIME_CHECK => undef, > + USE_ARMV8_CRC32C_WITH_RUNTIME_CHECK => 1, > > Shouldn't we only enable this flag when we are under aarch64? > Similarly, I don't think that it is a good idea to switch on > USE_SSE42_CRC32C_WITH_RUNTIME_CHECK all the time. We should only set > it when building under x86 and x86_64. > Ok, I will fix ARM64 specific one in the next revision. -- Niyas