Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHrRR-0006Dc-8y for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Jan 2023 19:16:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pHrRQ-0005P3-5F for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Jan 2023 19:16:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHrRP-0005Ot-Ry for pgsql-hackers@lists.postgresql.org; Tue, 17 Jan 2023 19:16:15 +0000 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHrRN-0006SR-3a for pgsql-hackers@postgresql.org; Tue, 17 Jan 2023 19:16:14 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 21BD32B066EA; Tue, 17 Jan 2023 14:16:11 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 17 Jan 2023 14:16:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673982970; x= 1673990170; bh=UcqVq1ZHgdxj5OWdyxqQPrzOQJjcDQMlTT10Z6YgSwQ=; b=p 9dVAm742fU9vWocvDBxjfQwSeWqoHK90gkQziOwzAwaJxXf182cJLZSrGrgCBUrZ xH9x2O++wBgh2mFM7wY+lRfX3AZOhQGsYnhm6AswILXDrOrd5pAxDcFoIkWWHPBZ G2JY7+9XARMZpms9btFwxVFAT53RE+PuunPJLapiUmRL5eBWD7sNUXTEItY8zkHl RGZl13UrHdTj5U52iMCvJurmXRxi7aGOvYSSXEyWnUQK3ApTRMvJQPDfr4Oz6ziH zw64NEPKtxemTb6SiQH990q0xErUSk3XOT6ag3k83Mr/bRCcSmwb0XwVfhNx7yjX 00aZhfKK1naTIeiCEOiMA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtiedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheprfgv thgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnh htvghrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepheelffeggedujeet iefhleetuddvieffhfffvdejvdffgeejkeduleduheduieefnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgr uhhtsegvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Jan 2023 14:16:09 -0500 (EST) Message-ID: <5ac14df0-eb4c-5eb0-4d74-27b49bbdd6bc@enterprisedb.com> Date: Tue, 17 Jan 2023 20:16:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Refactor recordExtObjInitPriv() Content-Language: en-US To: Nathan Bossart Cc: Tom Lane , pgsql-hackers References: <504bc485-6bd6-dd1b-fe10-e7351aeb310d@enterprisedb.com> <20230112000437.GA2032194@nathanxps13> <54b13402-b8ab-406a-d9a6-3542124ad6cf@enterprisedb.com> <1136333.1673544050@sss.pgh.pa.us> <20230112174049.GA2047702@nathanxps13> <20230116224321.GC2714038@nathanxps13> From: Peter Eisentraut In-Reply-To: <20230116224321.GC2714038@nathanxps13> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 16.01.23 23:43, Nathan Bossart wrote: > On Mon, Jan 16, 2023 at 12:01:47PM +0100, Peter Eisentraut wrote: >> I have updated the patch as you suggested and split out the aggregate issue >> into a separate patch for clarity. > > LGTM committed