Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXxyf-000822-Pb for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Sep 2022 04:56:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oXxye-0003Di-Js for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Sep 2022 04:56:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXxye-0003DZ-AP for pgsql-hackers@lists.postgresql.org; Tue, 13 Sep 2022 04:56:52 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXxyb-0007ra-LF for pgsql-hackers@postgresql.org; Tue, 13 Sep 2022 04:56:51 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id 670E26079E; Tue, 13 Sep 2022 13:56:44 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.7 at oss.nttdata.com MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 13 Sep 2022 13:56:44 +0900 From: Shinya Kato To: bt22kawamotok Cc: pgsql-hackers@postgresql.org Subject: Re: [PATCH]Feature improvement for MERGE tab completion In-Reply-To: <6c943aa7b6064b56e7ebeb901f7c24b4@oss.nttdata.com> References: <9f1ad2a87a58cd5e7d64f3993130958d@oss.nttdata.com> <359a46c295eae938d84552c11818ab62@oss.nttdata.com> <7d7eef0f596e449746766ff4fb7c9061@oss.nttdata.com> <6c943aa7b6064b56e7ebeb901f7c24b4@oss.nttdata.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <5b2e2880da33f6356931beb5c0d68c84@oss.nttdata.com> X-Sender: Shinya11.Kato@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-09-12 18:20, bt22kawamotok wrote: > Other than this correction, the parts that can be put together in OR > were corrected in fix_tab_completion_merge_v4.patch. When I tried to apply this patch, I got the following warning, please fix it. Other than that, I think everything is fine. $ git apply fix_tab_completion_merge_v4.patch fix_tab_completion_merge_v4.patch:38: trailing whitespace. else if (TailMatches("USING", MatchAny, "ON", MatchAny) || fix_tab_completion_merge_v4.patch:39: indent with spaces. TailMatches("USING", MatchAny, "AS", MatchAny, "ON", MatchAny) || fix_tab_completion_merge_v4.patch:40: indent with spaces. TailMatches("USING", MatchAny, MatchAny, "ON", MatchAny)) fix_tab_completion_merge_v4.patch:53: trailing whitespace. else if (TailMatches("WHEN", "MATCHED") || warning: 4 lines add whitespace errors. -- Regards, -- Shinya Kato Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION