Message-ID: <5b4cd32f-1d5b-c080-c688-31736bbcd739@gmail.com>
Date: Thu, 18 Apr 2024 23:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: cataloguing NOT NULL constraints
Content-Language: en-US
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>,
 Andrew Bille <andrewbille@gmail.com>, Peter Eisentraut
 <peter@eisentraut.org>, Robert Haas <robertmhaas@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: <202404181339.ql3wlpryz6kw@alvherre.pgsql>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <202404181339.ql3wlpryz6kw@alvherre.pgsql>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/5b4cd32f-1d5b-c080-c688-31736bbcd739%40gmail.com>
Precedence: bulk

Hello Alvaro,

18.04.2024 16:39, Alvaro Herrera wrote:
> I have pushed a fix which should hopefully fix this problem
> (d9f686a72e).  Please give this a look.  Thanks for reporting the issue.

Please look at an assertion failure, introduced with d9f686a72:
CREATE TABLE t(a int, NOT NULL a NO INHERIT);
CREATE TABLE t2() INHERITS (t);

ALTER TABLE t ADD CONSTRAINT nna NOT NULL a;
TRAP: failed Assert("lockmode != NoLock || IsBootstrapProcessingMode() || CheckRelationLockedByMe(r, AccessShareLock, 
true)"), File: "relation.c", Line: 67, PID: 2980258

On d9f686a72~1 this script results in:
ERROR:  cannot change NO INHERIT status of inherited NOT NULL constraint "t_a_not_null" on relation "t"

Best regards,
Alexander