Message-ID: <5b5f6cdd-e003-bbc2-7bed-b7847e9660b3@gmx.de>
Date: Sun, 15 Jan 2023 07:11:30 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: Doc: Rework contrib appendix -- informative titles, tweaked
 sentences
To: "Karl O. Pinc" <kop@karlpinc.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <20230102180015.372995a9@slate.karlpinc.com>
From: Brar Piening <brar@gmx.de>
In-Reply-To: <20230102180015.372995a9@slate.karlpinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:ezXErs3ADqg=;Exgv8zWdqIwV94NG7lho02ipDnW
 z0NC3zV5HcSCQsWEk5mTgE2lIsSiAJK6p1mk6n16o9HwngDe2VHghwobrEAQPNa/sBQK8ZVVy
 1tWS4lBVALSdDalPRxwc+bYa4Qf5snuTkvw0InrLgPREYO+um1QMVY/gjCDSBEgvWWRWaMEeb
 s9Wx3Cx4q1j3gmrEUyOpe2FEShQdBJVtD+pQ3u4oZfxQ8FxsdyBKjS/+naiDV+/B64xbcugOv
 MTjhyGLBw5oLTTOiCHYMIGrWvUL4QsWXIS4GdKwjUf2BNvwKEmyX9wOHhFtxRtpwB+3NvN/7Z
 dxZgn9s9Xeujavker0JRUcpOn1Zhb4cweo8m+PPYrsn6PSgisuIJI01GHrEBRQJgEGGKTgfVq
 FjABg5wXoQlPY+6aaBjIpiSh2vXFcBrc+KWYOzP36Jjxb14zUkvaGkE3IvMLCshZnCJvhOJWA
 wJVnXX+a02WmbWczv5fXzk/w9BzoIcpbnKifjm5gOdMlgynU0j8vmYGspYu/Pfg2rLFXim2hC
 RSLaDPjI8f+8ICqcV/WCWnGYi0f5LdHg05oiS36Oo5jRrG/yvqt8XsWyCqZSoEVWcB7LsJHyh
 SK9iNDbesHDa+fVXxkLSxLaswtMfIecJKEtdQjnBNNzhNpzRHw0Sl69BpS3gaOx8oeoVl3ye+
 mfXAdy0FQ3RUmucb0awr2yu1dGE09sK40pagtn0hG9y6CJa+Fiy+o1KEpfzl+OsO6Eb8uaBl/
 /evwayT3/wOnNwptg5a3VOdbcgw4OtJxQvHXaD/Fx9XeMWwXm6YBky3SDSBcH21QiU9z/3auq
 SMVV1crJszZMddiCc+bF3aXQiRU3jF8qKhROQnx4al1adbbyBFVleLBPMUWmMzhwc2p1md/zs
 vTi0+TIxXWj2gVgfW4mixrUXKxYhtllAn2syPMkuja6ZHd/rHEHudVyVGVia4FeyaNRW8ZMHW
 AqPRyBJAWhbTgajxmbVphwecdW0=
Archived-At: 
 <https://www.postgresql.org/message-id/5b5f6cdd-e003-bbc2-7bed-b7847e9660b3%40gmx.de>
Precedence: bulk

On 03.01.2023 at 01:00, Karl O. Pinc wrote:
> Attached is a patch: contrib_v1.patch
>
> It modifies Appendix F, the contrib directory.

Review:

The patch applies cleanly (1334b79a35 - 2023-01-14 18:05:09 +0900).

It adds a brief explanatory part to the headers of all contrib modules
which I consider as very useful, especially when looking at the TOC in
contrib.html where currently newcomers would need to click through all
the links to even get an idea what the various modules do.
The explanatory parts added make sense to me, althogh I'm not an expert
in all the different contrib modules.

Appendix=C2=A0F. now reads as "Additional Supplied Modules and Extensions"
instead of "Appendix=C2=A0F.=C2=A0Additional Supplied Modules" which IMHO =
proprely
reflects what it is about. The original title probably comes from the
pre-extension-era.

There is also some minor rewording of sentences in contrib.sgml that in
general looks like an improvment to me.

In conclusion I cannot see why this patch should not be applied in it's
current form so I deem it ready for commiter.

Regards,
Brar