Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oCJ46-0005ZY-5I
	for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Jul 2022 11:00:58 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oCJ45-0004Al-0v
	for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Jul 2022 11:00:57 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <d.koval@postgrespro.ru>)
	id 1oCJ44-00045R-GU
	for pgsql-hackers@lists.postgresql.org; Fri, 15 Jul 2022 11:00:56 +0000
Received: from mail.postgrespro.ru ([93.174.131.139])
	by magus.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <d.koval@postgrespro.ru>)
	id 1oCJ3y-0006mZ-IN
	for pgsql-hackers@lists.postgresql.org; Fri, 15 Jul 2022 11:00:55 +0000
Received: from [192.168.28.32] (cyclops.postgrespro.ru [93.174.131.138])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(Client did not present a certificate)
	by mail.postgrespro.ru (Postfix) with ESMTPSA id 1409521C0360;
	Fri, 15 Jul 2022 14:00:49 +0300 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru;
	s=mail; t=1657882849;
	bh=rGl+VGPwNFeztV8PnurpfjR6qB7jMUQkxb0leTynDXw=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To;
	b=MW7b38uZ7c9c2y98lX+wGFEU8bwyIeAsiL/Pte5/UbHBkrA4Psl2jiibXg3+TpAkf
	 JTMLyKk1yvAbGEMfROaeJJjTxs6B+H1gKixXFf2SVakYr/ZBSSi27j6Hmf90QaD3ft
	 I6gD1XNV1VEQiubsYRixo1OgrTq9XHJQ9s051mhA=
Message-ID: <5baa51c4-ee85-337a-6932-9fe8a85a1fed@postgrespro.ru>
Date: Fri, 15 Jul 2022 14:00:48 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Content-Language: en-US
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Zhihong Yu <zyu@yugabyte.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <20220714081214.s7cie3vbtyyshzuz@alvherre.pgsql>
From: Dmitry Koval <d.koval@postgrespro.ru>
In-Reply-To: <20220714081214.s7cie3vbtyyshzuz@alvherre.pgsql>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/5baa51c4-ee85-337a-6932-9fe8a85a1fed%40postgrespro.ru>
Precedence: bulk

> This is not a review, but I think the isolation tests should be
> expanded.  At least, include the case of serializable transactions being
> involved.

Thanks!
I will expand the tests for the next commitfest.

-- 
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com