Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nP4g4-0008IK-TN for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Mar 2022 15:44:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nP4g3-0007ja-Qr for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Mar 2022 15:44:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nP4g3-0007jK-HF for pgsql-hackers@lists.postgresql.org; Tue, 01 Mar 2022 15:44:39 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nP4g0-0006ga-K9 for pgsql-hackers@postgresql.org; Tue, 01 Mar 2022 15:44:38 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 06028E0006; Tue, 1 Mar 2022 15:44:29 +0000 (UTC) Message-ID: <5bbac9ff-09a4-61e7-5bf9-a74c75d84bf8@dunslane.net> Date: Tue, 1 Mar 2022 10:44:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: convert libpq uri-regress tests to tap test Content-Language: en-US From: Andrew Dunstan To: Tom Lane , Peter Eisentraut Cc: Andres Freund , pgsql-hackers@postgresql.org References: <20220223203031.ezrd73ohvjgfksow@alap3.anarazel.de> <1261838.1645657117@sss.pgh.pa.us> <4f4c04c2-f23c-6668-1b24-224fc6478bfd@enterprisedb.com> <1276236.1645667561@sss.pgh.pa.us> <95fdebab-adaa-4d00-165b-e58b9b63b94d@dunslane.net> In-Reply-To: <95fdebab-adaa-4d00-165b-e58b9b63b94d@dunslane.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2/24/22 07:19, Andrew Dunstan wrote: > On 2/23/22 20:52, Tom Lane wrote: >> Peter Eisentraut writes: >>> On 23.02.22 23:58, Tom Lane wrote: >>>> Peter Eisentraut writes: >>>>> libpq TAP tests should be in src/interfaces/libpq/t/. >>>> That's failing to account for the fact that a libpq test can't >>>> really be a pure-perl TAP test; you need some C code to drive the >>>> library. >>> Such things could be put under src/interfaces/libpq/test, or some other >>> subdirectory. We already have src/interfaces/ecpg/test. >> OK, but then the TAP scripts are under src/interfaces/libpq/test/t, >> which isn't what you said. I have no great objection to moving >> src/test/modules/libpq_pipeline/ to src/interfaces/libpq/test/, >> though, as long as the buildfarm will cope. >> >> > > It won't without some adjustment. See and cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com