Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1j5a2i-0000lp-O8
	for pgsql-hackers@arkaria.postgresql.org; Sat, 22 Feb 2020 19:02:25 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1j5a2h-00089h-HP
	for pgsql-hackers@arkaria.postgresql.org; Sat, 22 Feb 2020 19:02:23 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql@j-davis.com>)
	id 1j5a2h-00089a-10
	for pgsql-hackers@lists.postgresql.org; Sat, 22 Feb 2020 19:02:23 +0000
Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <pgsql@j-davis.com>)
	id 1j5a2e-0005lb-Hu
	for pgsql-hackers@postgresql.org; Sat, 22 Feb 2020 19:02:21 +0000
Received: by mail-pf1-x429.google.com with SMTP id x185so3075809pfc.5
        for <pgsql-hackers@postgresql.org>;
 Sat, 22 Feb 2020 11:02:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=j-davis-com.20150623.gappssmtp.com; s=20150623;
        h=message-id:subject:from:to:cc:date:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=Fp2G4hmRkghtZYJZgjwOsogzvMJlL9nykSJp+P8YScs=;
        b=XITjB4nYjJPonLxuTbdK9CA225jEvpIgrJlJuOutCu7aFre3DC7Pu4tpRgXZPmPIp1
         YzApHV4wyJ3nnkkS/dgDCcZQL8oEZjZF5MoHaTAKx4HnLKsrDasDfhz4HtknEs2vudIo
         d7dc/f7Pn4xbUZbMHLIeDsdE4Rc92syeKFatxEp6MGe71P9u6Di0+s+jPpWoxNnxeG4/
         pJDwHOnLnBcnswg8Y/KkbKelK9k92PPZONk+bCjqDkjpzAzJ8w/hOXB66+k3IfWE/apc
         fWkibY6BqPU3r7LzjCwYKrEo8I1EU6jtKSsNNL9MlHg72fcCAlwoW5difuLhcTksoZTf
         5Upw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=Fp2G4hmRkghtZYJZgjwOsogzvMJlL9nykSJp+P8YScs=;
        b=TErrbA2BIMCI3XN9/xPNENFGVbpxO6Bs1ATTAPknOGUohOrZQ2rBE5PDGQDc62hsP0
         RoF+EWKpl+IupDvM5CHRRviS/DOSyLZdWvARkNb5/4ECMgvd56BYyHct6fe33rnWuWh8
         6Aan7BxOVNzE9VmI8sLZAZdJvXGoPGdNE/q5S8T27HiaZxJuhczYasM3CYFMecVtIlNX
         NO1JC+FlDhH8Qn8+nqs6pTj2vVQZ9QpyLxYIrk8CXw/t0f1Gp+4FLQLJOkHJPEOd63M8
         VLC0QcybyO82oHmE9kCPo7ua+PAEqPHvf8WJsOl7ufgiCVdZgVuZITEDjLC8qyhe2MSW
         kpqg==
X-Gm-Message-State: APjAAAXKsw2T/dei3FRVwHysiteJdSOPXC18AnMjdba1bfvHVRW35jNZ
	z3CHmLEmpLk9zMA1Q5R3Oyp/kw==
X-Google-Smtp-Source: 
 APXvYqzW23VPILRa2ABe+/rY9k11Gt9IUgzS2gY6VhctScSTCR3cJ/U+26Myj3u6UT9etumLGmxV/w==
X-Received: by 2002:a65:40c8:: with SMTP id u8mr41541506pgp.188.1582398139359;
        Sat, 22 Feb 2020 11:02:19 -0800 (PST)
Received: from jdavis.lan (c-73-231-146-4.hsd1.ca.comcast.net. [73.231.146.4])
        by smtp.gmail.com with ESMTPSA id
 y197sm7348971pfc.79.2020.02.22.11.02.17
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Sat, 22 Feb 2020 11:02:18 -0800 (PST)
Message-ID: <5c371df7cee903e8cd4c685f90c6c72086d3a2dc.camel@j-davis.com>
Subject: Re: Memory-Bounded Hash Aggregation
From: Jeff Davis <pgsql@j-davis.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, Melanie Plageman
 <melanieplageman@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>, Taylor
 Vesely <tvesely@pivotal.io>, Adam Lee <ali@pivotal.io>, Melanie Plageman
 <mplageman@pivotal.io>,  Pg Hackers <pgsql-hackers@postgresql.org>
Date: Sat, 22 Feb 2020 11:02:16 -0800
In-Reply-To: <20200222180020.ej5gvfcaf2semgji@alap3.anarazel.de>
References: <e52707d4665e32867fb6dd181825ef15f853b8bf.camel@j-davis.com>
	 <20191214173225.3kzsbncr6brpxdll@development>
	 <d72e494db7b075ef02c3163e6614e698701d2c3e.camel@j-davis.com>
	 <775d754c-9a61-5363-6998-f87d15f1b592@iki.fi>
	 <CAAKRu_aefEsv+UkQWqu+ioEnoiL2LJu9Diuh9BR8MbyXuZ0j4A@mail.gmail.com>
	 <20200218185749.srk733n4z57lzxf2@development>
	 <7612ea4d636b6341d0606f4e852d584798e04901.camel@j-davis.com>
	 <20200219191636.gvdywx32kwbix6kd@development>
	 <20200221202212.ssb2qpmdgrnx52sj@alap3.anarazel.de>
	 <9759ab2d0c2c28a175e11efe1788d37dc7e1b768.camel@j-davis.com>
	 <20200222180020.ej5gvfcaf2semgji@alap3.anarazel.de>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On Sat, 2020-02-22 at 10:00 -0800, Andres Freund wrote:
> Both patches, or just 0013? Seems the earlier one might make the
> addition of the opcodes you add less verbose?

Just 0013, thank you. 0008 looks like it will simplify things.

Regards,
	Jeff Davis