Content-Type: multipart/alternative;
 boundary="------------x8UUuI0YVaGftnHyv09wpL0B"
Message-ID: <5d37428e-0753-e721-8e77-81cc4d0dc9f1@dunslane.net>
Date: Thu, 25 Jan 2024 10:40:26 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: More new SQL/JSON item methods
Content-Language: en-US
To: Jeevan Chalke <jeevan.chalke@enterprisedb.com>,
 Peter Eisentraut <peter@eisentraut.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAM2+6=XjTyqrrqHAOj80r0wVQxJSxc0iyib9bPC55uFO9VKatg@mail.gmail.com>
 <bc03e76e-15d6-744e-db53-2e4417b5fe05@dunslane.net>
 <CAM2+6=UCSp74devvHYpMx5NvpyWbCO3gYvgpEYHtNYqF2j6Z9Q@mail.gmail.com>
 <c3158517-940d-278e-d9ea-846c65430a14@dunslane.net>
 <CAM2+6=UrDfcsz0xn+oUmomOnPYazuP8dAM_Wrx5YMsWxXjWyKA@mail.gmail.com>
 <d37da0bc-204a-125a-dfeb-c3d7cc639d69@dunslane.net>
 <CAM2+6=UMCtXVSk1NmGHzsYYY6xGdnaMMKxVaKUtG7o0jkiuyQg@mail.gmail.com>
 <e913dde5-0209-441c-8040-dd2ace6415e0@eisentraut.org>
 <fa454906-7539-4070-b51a-2e7dcfb6b741@eisentraut.org>
 <CAM2+6=XPHNJnGypXy2C_5TUWgCxCktz1GrwuzsSZSqb_R+pMXQ@mail.gmail.com>
 <CAM2+6=WYbL4gxpmEJcN5BvLYuMZUpruLQRZxFeKTBNNpksgN=g@mail.gmail.com>
 <cc883de1-ae89-438b-a97e-926ad332f5ba@eisentraut.org>
 <CAM2+6=WyoinYoiuf3msxqH-hsPBoUz33MmrCpD_4Ceo6Nq1qOg@mail.gmail.com>
 <1d092c02-8249-4e56-8b8e-ae4db95b8fde@eisentraut.org>
 <CAM2+6=Wys-tgwA15WkgW+8uR0SKncFLZuj0B+ukjvxbrebz9qQ@mail.gmail.com>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: 
 <CAM2+6=Wys-tgwA15WkgW+8uR0SKncFLZuj0B+ukjvxbrebz9qQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/5d37428e-0753-e721-8e77-81cc4d0dc9f1%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------x8UUuI0YVaGftnHyv09wpL0B
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2024-01-18 Th 09:25, Jeevan Chalke wrote:
>
>
> On Thu, Jan 18, 2024 at 1:03 AM Peter Eisentraut 
> <peter@eisentraut.org> wrote:
>
>     On 17.01.24 10:03, Jeevan Chalke wrote:
>     > I added unary '+' and '-' support as well and thus thought of
>     having
>     > separate rules altogether rather than folding those in.
>     >
>     >     Per SQL standard, the precision and scale arguments are unsigned
>     >     integers, so unary plus and minus signs are not supported. 
>     So my patch
>     >     removes that support, but I didn't adjust the regression
>     tests for that.
>     >
>     >
>     > However, PostgreSQL numeric casting does support a negative
>     scale. Here
>     > is an example:
>     >
>     > # select '12345'::numeric(4,-2);
>     >   numeric
>     > ---------
>     >     12300
>     > (1 row)
>     >
>     > And thus thought of supporting those.
>     > Do we want this JSON item method to behave differently here?
>
>     Ok, it would make sense to support this in SQL/JSON as well.
>
>
> OK. So with this, we don't need changes done in your 0001 patches.
>
>
>     > I will merge them all into one and will try to keep them in the
>     order
>     > specified in sql_features.txt.
>     > However, for documentation, it makes more sense to keep them in
>     logical
>     > order than the alphabetical one. What are your views on this?
>
>     The documentation can be in a different order.
>
>
> Thanks, Andrew and Peter for the confirmation.
>
> Attached merged single patch along these lines.


Thanks, I have pushed this.


cheers


andrew


--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------x8UUuI0YVaGftnHyv09wpL0B
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2024-01-18 Th 09:25, Jeevan Chalke
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAM2+6=Wys-tgwA15WkgW+8uR0SKncFLZuj0B+ukjvxbrebz9qQ@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">
        <div dir="ltr"><br>
        </div>
        <br>
        <div class="gmail_quote">
          <div dir="ltr" class="gmail_attr">On Thu, Jan 18, 2024 at
            1:03 AM Peter Eisentraut &lt;<a
              href="mailto:peter@eisentraut.org" moz-do-not-send="true"
              class="moz-txt-link-freetext">peter@eisentraut.org</a>&gt;
            wrote:<br>
          </div>
          <blockquote class="gmail_quote" style="margin:0px 0px 0px
            0.8ex;border-left:1px solid
            rgb(204,204,204);padding-left:1ex">On 17.01.24 10:03, Jeevan
            Chalke wrote:<br>
            &gt; I added unary '+' and '-' support as well and thus
            thought of having <br>
            &gt; separate rules altogether rather than folding those in.<br>
            &gt; <br>
            &gt;     Per SQL standard, the precision and scale arguments
            are unsigned<br>
            &gt;     integers, so unary plus and minus signs are not
            supported.  So my patch<br>
            &gt;     removes that support, but I didn't adjust the
            regression tests for that.<br>
            &gt; <br>
            &gt; <br>
            &gt; However, PostgreSQL numeric casting does support a
            negative scale. Here <br>
            &gt; is an example:<br>
            &gt; <br>
            &gt; # select '12345'::numeric(4,-2);<br>
            &gt;   numeric<br>
            &gt; ---------<br>
            &gt;     12300<br>
            &gt; (1 row)<br>
            &gt; <br>
            &gt; And thus thought of supporting those.<br>
            &gt; Do we want this JSON item method to behave differently
            here?<br>
            <br>
            Ok, it would make sense to support this in SQL/JSON as well.<br>
          </blockquote>
          <div><br>
          </div>
          <div>OK. So with this, we don't need changes done in your 0001
            patches.</div>
          <div> </div>
          <blockquote class="gmail_quote" style="margin:0px 0px 0px
            0.8ex;border-left:1px solid
            rgb(204,204,204);padding-left:1ex">
            <br>
            &gt; I will merge them all into one and will try to keep
            them in the order <br>
            &gt; specified in sql_features.txt.<br>
            &gt; However, for documentation, it makes more sense to keep
            them in logical <br>
            &gt; order than the alphabetical one. What are your views on
            this?<br>
            <br>
            The documentation can be in a different order.<br>
          </blockquote>
          <div><br>
          </div>
          <div>Thanks, Andrew and Peter for the confirmation.</div>
          <div><br>
          </div>
          <div dir="ltr">Attached merged single patch along these lines.<br>
            <span style="font-size:11pt;font-family:Arial;color:rgb(255,62,0);background-color:rgb(255,255,255);font-weight:700;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">


</span></div>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p>Thanks, I have pushed this.</p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <p><br>
    </p>
    <pre class="moz-signature" signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------x8UUuI0YVaGftnHyv09wpL0B--