Message-ID: <5d3a24216d15ce8a50d0fc085a13a410202014ca.camel@j-davis.com>
Subject: Re: Statistics Import and Export
From: Jeff Davis <pgsql@j-davis.com>
To: Corey Huinker <corey.huinker@gmail.com>, Bruce Momjian <bruce@momjian.us>
Cc: jian he <jian.universality@gmail.com>, Matthias van de Meent
 <boekewurm+postgres@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Nathan
 Bossart <nathandbossart@gmail.com>, Magnus Hagander <magnus@hagander.net>,
 Stephen Frost <sfrost@snowman.net>, Ashutosh Bapat
 <ashutosh.bapat.oss@gmail.com>, Peter Smith <smithpb2250@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, 
 alvherre@alvh.no-ip.org
Date: Mon, 25 Nov 2024 20:10:22 -0800
In-Reply-To: <CADkLM=cxNaU3O40Y5zGARJBWm-uAvb2hvgZxd=tOu-zTsrHpkQ@mail.gmail.com>
References: 
	<CADkLM=eu72o_=s2ARNe8yB-16AUm+_iU0tq_ALeeUUxCCqJkOQ@mail.gmail.com>
	 <11bb2c7403d4a7421fe8b09df6737aa83976266e.camel@j-davis.com>
	 <CACJufxHrJb3L66kzYWeFvN_7RNROaHKUo_JuXK6B64c+TkWOhA@mail.gmail.com>
	 <CADkLM=edhVxHr5OGZHnUeoMkjFYNpE==puOKbB1E_7j1=QsbBw@mail.gmail.com>
	 <CACJufxGmdV-9c7M_fs-2mGBMj1XiVqdOkW0NvibmpBJqedo1uQ@mail.gmail.com>
	 <CADkLM=eErgzn7ECDpwFcptJKOk9SxZEk5Pot4d94eVTZsvj3gw@mail.gmail.com>
	 <be7de51af6e969d501f69426c7137af6bde17fdc.camel@j-davis.com>
	 <CADkLM=eSnbrOPfof8JeSZriFXnqpYcyRw8-WhL5nesbkduDdUQ@mail.gmail.com>
	 <CADkLM=fR7TwH0cLREQkf5_=KLcOYVxJw0Km0i5MpaWeuDwVo6g@mail.gmail.com>
	 <CADkLM=fBaHichB7oS=LZNfTpGHSOTO44OKR28BwNmwu+9PicOg@mail.gmail.com>
	 <ZzuZzDMxe3ClqAgF@momjian.us>
	 <CADkLM=cxNaU3O40Y5zGARJBWm-uAvb2hvgZxd=tOu-zTsrHpkQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/5d3a24216d15ce8a50d0fc085a13a410202014ca.camel%40j-davis.com>
Precedence: bulk

On Mon, 2024-11-18 at 20:29 -0500, Corey Huinker wrote:
> Attached is a re-basing of the existing patchset, plus 3 more
> additions:

Comments on 0003:

* If we commit 0003, is it a useful feature by itself or does it
require that we commit some or all of 0004-0014? Which of these need to
be in v18?

* Why does binary upgrade cause statistics to be dumped? Can you just
make pg_upgrade specify the appropriate set of flags?

* It looks like appendNamedArgument() is never called with
positional=3Dtrue?

* It's pretty awkward to use an array of arrays of strings when an
array of structs might make more sense.


Regards,
	Jeff Davis