Subject: Re: [HACKERS] logical decoding of two-phase transactions
To: Arseny Sher <a.sher@postgrespro.ru>
Cc: Nikhil Sontakke <nikhils@2ndquadrant.com>,
 Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>,
 David Steele <david@pgmasters.net>,
 Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
 Simon Riggs <simon@2ndquadrant.com>, Craig Ringer <craig@2ndquadrant.com>,
 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
 Petr Jelinek <petr.jelinek@2ndquadrant.com>,
 Sokolov Yura <y.sokolov@postgrespro.ru>,
 Stas Kelvich <s.kelvich@postgrespro.ru>,
 Dmitry Dolgov <9erthalion6@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 Masahiko Sawada <sawada.mshk@gmail.com>,
 PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
References: <20180719194208.j5m7qhdmqp46d6yg@alap3.anarazel.de>
 <CAMGcDxfgg8yP0MsdKRuqwihkrQF=0Mz9Se+0paNGADWaexULjQ@mail.gmail.com>
 <20180720145836.gxwhbftuoyx5h4gc@alap3.anarazel.de>
 <CAMGcDxebtC_ZO6EtLA1MgJ6sWbud3Fjtq9HsBwxxhYfoHJdANw@mail.gmail.com>
 <20180723135009.w25re6qxbb7njrbd@alap3.anarazel.de>
 <CAMGcDxdJNZVq1mX9dZbwEniigi=af8H5dt62C+q2UHwsE+BTaw@mail.gmail.com>
 <20180723141435.ercxxh3bj2uc2mjm@alap3.anarazel.de>
 <3B37B16B-A473-4352-ABCF-F23AE314D4F7@2ndquadrant.com>
 <CAMGcDxeBcMBF0KZ9qMpcb07uX6uLNO5hk=VWCQC514oZuofLmw@mail.gmail.com>
 <20180726200241.aje4dv4jsv25v4k2@alap3.anarazel.de>
 <CAMGcDxfVBiBXt4F7v58_DfqFD9xnmU8hBEiyqoypon6Ftroe_Q@mail.gmail.com>
 <a5ba1686-bb79-f2c3-568d-993e4c53b920@2ndquadrant.com>
 <CAMGcDxfWORpkaOaNhFwS4839R_w4wtDgnB8Wj2TmAQXnV78HsQ@mail.gmail.com>
 <CAMGcDxe276HwzQ1ErqMHKPf=KTvdSGgu3jYaR+j3-368+amZSA@mail.gmail.com>
 <2ba9c978-ede8-35bf-14ec-45570bf0f6aa@2ndquadrant.com>
 <87h8fbxjxw.fsf@ars-thinkpad>
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Message-ID: <5d4ec920-7a88-476c-b492-c0bf1ee76ebc@2ndquadrant.com>
Date: Tue, 18 Dec 2018 15:44:47 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.1
MIME-Version: 1.0
In-Reply-To: <87h8fbxjxw.fsf@ars-thinkpad>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/18/18 10:28 AM, Arseny Sher wrote:
> 
> Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> 
>> Hi Nikhil,
>>
>> Thanks for the updated patch - I've started working on a review, with
>> the hope of getting it committed sometime in 2019-01. But the patch
>> bit-rotted again a bit (probably due to d3c09b9b), which broke the last
>> part. Can you post a fixed version?
> 
> Please also note that at some time the thread was torn and continued in
> another place:
> https://www.postgresql.org/message-id/flat/CAMGcDxeqEpWj3fTXwqhSwBdXd2RS9jzwWscO-XbeCfso6ts3%2BQ%40mail.gmail.com
> 
> And now we have two branches =(
> 

Thanks for pointing that out - I've added the other thread to the CF
entry, so that we don't loose it.

> I hadn't checked whether my concerns where addressed in the latest
> version though.
> 

OK, I'll read through the other thread and will check. Or perhaps Nikhil
can comment on that.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services