Message-ID: <5d8f802d0cc1871ac4bd9450ba98ce8d0626bb58.camel@cybertec.at>
Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensure
 clean shutdown)
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Alvaro Herrera <alvherre@2ndquadrant.com>, Paul Guo <pguo@pivotal.io>
Cc: Michael Paquier <michael@paquier.xyz>, Thomas Munro
 <thomas.munro@gmail.com>,  pgsql-hackers <pgsql-hackers@postgresql.org>,
 Jimmy Yih <jyih@pivotal.io>, Ashwin Agrawal <aagrawal@pivotal.io>,  Alexey
 Kondratov <a.kondratov@postgrespro.ru>
Date: Wed, 25 Sep 2019 21:26:54 +0200
In-Reply-To: <20190925174812.GA4916@alvherre.pgsql>
References: <20190925174812.GA4916@alvherre.pgsql>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.32.4 (3.32.4-1.fc30) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2019-09-25 at 14:48 -0300, Alvaro Herrera wrote:
> Another thing in 0002 is that you're adding a "-R" switch to
> pg_rewind, but we have another patch in the commitfest using the same
> switch for a different purpose.  Maybe you guys need to get to an
> agreement over who uses the letter :-)  Also, it would be super
> helpful if you review Alexey's patch:
> https://commitfest.postgresql.org/24/1849/

I believe that -R should be reserved for creating recovery.conf,
similar to pg_basebackup.

Everything else would be confusing.

I've been missing pg_rewind -R!

Yours,
Laurenz Albe