Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXNW1-0000AN-B6 for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Mar 2023 14:33:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pXNVz-0005m1-Qf for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Mar 2023 14:33:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXNVz-0005lq-Fz for pgsql-hackers@lists.postgresql.org; Wed, 01 Mar 2023 14:33:07 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pXNVw-0005lg-CG for pgsql-hackers@lists.postgresql.org; Wed, 01 Mar 2023 14:33:06 +0000 Received: by mail-wm1-x330.google.com with SMTP id m25-20020a7bcb99000000b003e7842b75f2so7962403wmi.3 for ; Wed, 01 Mar 2023 06:33:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dquSoOB4Jr2qjlmhf8+jcBj7iPzCosFCq6EIcYSKOUY=; b=KfE9ubRhclgzdZ/tCsGZaMB/m51wDqHyk8PXrTJaxO5aZahcxnR898yQkzsbsVNt9S ZS8tbBU4FwZxgLuqh+QtxMUJbX0r8pM53vmOM4I1moaYF2tRLP6kNDilQIFgJ1YIJM7E An43gvz6Wx8ss9/djwcobzu+yzgwoaqrAZAuh+gevZFAOexfFm/uheuW36l4plNyiYUW knFq33V49DYYlIo0/5YbNzHrCfSsHHoqBb70S3/4MWAPkhxUyjkiROuUaC93FtVL8gzZ ymdOHOYnc+/zLaRlEVSOUTt90ZrCsW9Y4I/M9+sM70TzIj+yryS6ZlhMiIBlkGkzzHtk ZVAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dquSoOB4Jr2qjlmhf8+jcBj7iPzCosFCq6EIcYSKOUY=; b=3hEdwsehTtcDcJoJk3phRgY5cvbONiUYbLuQ83kcKyLYM5wW4Bp6kJBgaXf7e8vrFX V8cD8bhDeh+rRVOmqvIQt2P2977Ral1ILVMeMO+mO0qu3k0Leo43xgrH9MCVrbN7bTYN 3evWaiT4K1rPxroGVFCPcuSxlBLhY8dzmvleofofrJabyxPT/yZw4chA2/HolDHIfJUA KWrNGAkHq3B6/jovp8MSd7pzxkWhIDnOwsKD7UX6BbKs8vIB132cL0r5Y0kDBL1Exy6L 580E8dq7mlAELELK4vVIKgrVg4KTlYwWkpui0vDEw3uVSQPlEqSBsz24v9OSBTz24rgs KSlQ== X-Gm-Message-State: AO0yUKWrn+mx63POlWtpjbFW/P1f7i3cPXMVJUy2IxopvssEE34gboeI HcCCotZj8h4dBid93Mb92x9XMYDTSRJhFwGv1FHA/J6JJ7HhCliOwQuoWsqNMeAH1y8rT0JRqeD Jcw8F5TWtJjm3fogvzRbFAzjvpLSjDlE7zKAzA8gqwdbjI6TNJAQGGNEiXMMaj2r/DtiNND+kkI Aqx2D3QS24sTf0loMh8eLB1gweId05BHnQP0fw8yXyGE/uN39co9/K X-Google-Smtp-Source: AK7set+AenT1l6+HIIy8AG+Mdlrb9+BEMTD4WFBSpBHVTjRqUfL7XosaTopNes2YNfk9BvnuG6W3mw== X-Received: by 2002:a05:600c:540a:b0:3eb:fc6:79cf with SMTP id he10-20020a05600c540a00b003eb0fc679cfmr5487898wmb.6.1677681181612; Wed, 01 Mar 2023 06:33:01 -0800 (PST) Received: from [10.137.0.17] (static-84-42-175-93.bb.vodafone.cz. [84.42.175.93]) by smtp.gmail.com with ESMTPSA id 21-20020a05600c229500b003e1f2e43a1csm15801117wmf.48.2023.03.01.06.33.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Mar 2023 06:33:01 -0800 (PST) Message-ID: <5da177e0-42d3-9426-964e-858861c42e53@enterprisedb.com> Date: Wed, 1 Mar 2023 15:33:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Add LZ4 compression in pg_dump To: Michael Paquier , Justin Pryzby Cc: gkokolatos@pm.me, shiy.fnst@fujitsu.com, pgsql-hackers@lists.postgresql.org, Rachel Heaton References: <6YZqN2HEE4yJxxxXWiMl4QWwKzLon0SdKETTGVkT9zjWnXMftGZjLKHHjGFuwC_5I6xL2s8nMXdLQGA4vEFveYXSHbfD9K9pDQvEJF2y99o=@pm.me> <535565cd-b69f-c064-a845-15c0fc44db4a@enterprisedb.com> <22cb80ed-ec87-54c7-fd5b-cdcf79766bb1@enterprisedb.com> <8421f53d-c9f7-c02e-3278-9f9522a8e8f3@enterprisedb.com> <20230228235834.GC30529@telsasoft.com> Content-Language: en-US From: Tomas Vondra In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/1/23 08:24, Michael Paquier wrote: > On Tue, Feb 28, 2023 at 05:58:34PM -0600, Justin Pryzby wrote: >> I found that e9960732a broke writing of empty gzip-compressed data, >> specifically LOs. pg_dump succeeds, but then the restore fails: > > The number of issues you have been reporting here begins to worries > me.. How many of them have you found? Is it right to assume that all > of them have basically 03d02f5 as oldest origin point? AFAICS a lot of the issues are more a discussion about wording in a couple places, whether it's nicer to do A or B, name the functions differently or what. I'm aware of three genuine issues that I intend to fix shortly: 1) incorrect "if" condition in a TAP test 2) failure when compressing empty LO (which we had no test for) 3) change in handling "compression level = 0" (which I believe should be made to behave like before) regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company