pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedRemove obsolete options for createuser
3+ messages / 2 participants
[nested] [flat]
* Remove obsolete options for createuser
@ 2019-10-19 12:34 Alexander Lakhin <exclusion@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Lakhin @ 2019-10-19 12:34 UTC (permalink / raw)
To: pgsql-hackers
Hello hackers,
I've noticed that the createuser utility supports two undocumented
options (--adduser, --no-adduser), that became obsolete in 2005.
I believe that their existence should come to end someday (maybe
today?). The patch to remove them is attached.
Best regards.
Alexander
Attachments:
[text/x-patch] remove-createuser-adduser.patch (1.1K, ../../5da284a2-62d9-e338-88d1-26ee5009d93e@gmail.com/2-remove-createuser-adduser.patch)
download | inline diff:
diff --git a/src/bin/scripts/createuser.c b/src/bin/scripts/createuser.c
index 973ba525b2..c8db5e0bd1 100644
--- a/src/bin/scripts/createuser.c
+++ b/src/bin/scripts/createuser.c
@@ -43,9 +43,6 @@ main(int argc, char *argv[])
{"replication", no_argument, NULL, 1},
{"no-replication", no_argument, NULL, 2},
{"interactive", no_argument, NULL, 3},
- /* adduser is obsolete, undocumented spelling of superuser */
- {"adduser", no_argument, NULL, 'a'},
- {"no-adduser", no_argument, NULL, 'A'},
{"connection-limit", required_argument, NULL, 'c'},
{"pwprompt", no_argument, NULL, 'P'},
{"encrypted", no_argument, NULL, 'E'},
@@ -88,7 +85,7 @@ main(int argc, char *argv[])
handle_help_version_opts(argc, argv, "createuser", help);
- while ((c = getopt_long(argc, argv, "h:p:U:g:wWedDsSaArRiIlLc:PE",
+ while ((c = getopt_long(argc, argv, "h:p:U:g:wWedDsSrRiIlLc:PE",
long_options, &optindex)) != -1)
{
switch (c)
@@ -121,11 +118,9 @@ main(int argc, char *argv[])
createdb = TRI_NO;
break;
case 's':
- case 'a':
superuser = TRI_YES;
break;
case 'S':
- case 'A':
superuser = TRI_NO;
break;
case 'r':
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Remove obsolete options for createuser
@ 2019-10-21 04:33 Michael Paquier <michael@paquier.xyz>
parent: Alexander Lakhin <exclusion@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Michael Paquier @ 2019-10-21 04:33 UTC (permalink / raw)
To: Alexander Lakhin <exclusion@gmail.com>; +Cc: pgsql-hackers
On Sat, Oct 19, 2019 at 03:34:56PM +0300, Alexander Lakhin wrote:
> I've noticed that the createuser utility supports two undocumented
> options (--adduser, --no-adduser), that became obsolete in 2005.
> I believe that their existence should come to end someday (maybe
> today?). The patch to remove them is attached.
The commit in question is 8ae0d47 from 2005. So let's remove it. It
is not even documented for ages.
Perhaps somebody thinks it is not a good idea?
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../20191021043308.GJ1542@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Remove obsolete options for createuser
@ 2019-10-23 03:28 Michael Paquier <michael@paquier.xyz>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 3+ messages in thread
From: Michael Paquier @ 2019-10-23 03:28 UTC (permalink / raw)
To: Alexander Lakhin <exclusion@gmail.com>; +Cc: pgsql-hackers
On Mon, Oct 21, 2019 at 01:33:08PM +0900, Michael Paquier wrote:
> The commit in question is 8ae0d47 from 2005. So let's remove it. It
> is not even documented for ages.
>
> Perhaps somebody thinks it is not a good idea?
Done. A similar move could be done for --encrypted which has been
made a no-op as of eb61136, still that feels way too early.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../20191023032830.GC3286@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2019-10-23 03:28 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-10-19 12:34 Remove obsolete options for createuser Alexander Lakhin <exclusion@gmail.com>
2019-10-21 04:33 ` Michael Paquier <michael@paquier.xyz>
2019-10-23 03:28 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox