Message-ID: <5dc12198-80ff-4e70-b187-11ef33418411@enterprisedb.com>
Date: Wed, 17 Jul 2024 00:14:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: RFC: pg_stat_logmsg
To: Joe Conway <mail@joeconway.com>, Gurjeet Singh <gurjeet@singh.im>,
 Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <89742024-d51a-c66b-90b9-67f837072cd2@joeconway.com>
 <CAD21AoAyPVYZ_6VAQCOanvHTL3CRSqTDCFrtvaYVGwOQbrnxgQ@mail.gmail.com>
 <CABwTF4VzMJaTLrpYtBj4n9r73TFjffzqpPFeUmJPrkY6cmHEAg@mail.gmail.com>
 <3b1683bc-2630-a0d0-6083-8a45aa1b54bf@joeconway.com>
 <cda17e6d-f625-b45e-dfb9-8d18ed09ecc5@joeconway.com>
Content-Language: en-US
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: <cda17e6d-f625-b45e-dfb9-8d18ed09ecc5@joeconway.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/5dc12198-80ff-4e70-b187-11ef33418411%40enterprisedb.com>
Precedence: bulk

Hi,

I noticed this patch hasn't moved since September 2023, so I wonder
what's the main blocker / what is needed to move this?

As for the feature, I've never done a fleet-wide analysis, so if this is
one of the main use cases, I'm not really sure I can judge if this is a
good tool for that. It seems like it might be a convenient way to do
that, but does that require we add the module to contrib?

As for the code, I wonder if the instability of line numbers could be a
problem - these can change (a little bit) between minor releases, so
after an upgrade we'll read the dump file with line numbers from the old
release, and then start adding entries with new line numbers. Do we need
to handle this in some way?

This might be partially solved by eviction of entries from the old
release - we apply decay, so after a while their usage will be 0. But
what if there's no pressure for space, we'll not actually evict them.
And it'll be confusing to have a mix of old/new line numbers.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company