public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew Dunstan <[email protected]>
To: Andres Freund <[email protected]>
Cc: [email protected]
Cc: Robert Haas <[email protected]>
Cc: Thomas Munro <[email protected]>
Subject: Re: Should we add a compiler warning for large stack frames?
Date: Fri, 12 Apr 2024 08:29:29 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
On 2024-04-11 Th 16:17, Andres Freund wrote:
> 128k is probably not going to be an issue in practice. However, it also seems
> not great from a performance POV to use this much stack in a function that's
> called fairly often. I'd allocate the buffer in verify_backup_checksums() and
> reuse it across all to-be-checked files.
>
>
Yes, I agree. I'll make that happen in the next day or two.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Should we add a compiler warning for large stack frames?
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox