Message-ID: <5e28b89f-0033-4e42-8184-b71b731c1aa2@iki.fi>
Date: Thu, 16 Nov 2023 15:33:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: psql not responding to SIGINT upon db reconnection
Content-Language: en-US
To: Tristan Partin <tristan@neon.tech>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org,
 Shlok Kyal <shlok.kyal.oss@gmail.com>
References: <CUAJJDVD8L61.2AH6VEEDMTXX3@gonk> <CUAKHCX5472I.SJP0AWQRYVFA@gonk>
 <CUAKIOVISECO.2S7MSQFOP1304@gonk> <1588058.1690220636@sss.pgh.pa.us>
 <CUAO24Z1Y72E.2069AD01EB4LO@gonk>
 <CANhcyEVBQWoPJK+C_h1CKyN3Wr2VKHuPx=bSB4PH2LuGdut4qg@mail.gmail.com>
 <CWRWDTTPP0WZ.2W75ZAVL5ND1M@neon.tech>
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <CWRWDTTPP0WZ.2W75ZAVL5ND1M@neon.tech>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/5e28b89f-0033-4e42-8184-b71b731c1aa2%40iki.fi>
Precedence: bulk

On 06/11/2023 19:16, Tristan Partin wrote:
>>> That sounds like a much better solution. Attached you will find a v4
>>> that implements your suggestion. Please let me know if there is
>>> something that I missed. I can confirm that the patch works.

This patch is missing a select(). It will busy loop until the connection 
is established or cancelled.

Shouldn't we also clear CancelRequested after we have cancelled the 
attempt? Otherwise, any subsequent attempts will immediately fail too.

Should we use 'cancel_pressed' here rather than CancelRequested? To be 
honest, I don't understand the difference, so that's a genuine question. 
There was an attempt at unifying them in the past but it was reverted in 
commit 5d43c3c54d.

-- 
Heikki Linnakangas
Neon (https://neon.tech)