Subject: Re: [HACKERS] Small improvement to compactify_tuples
To: Andres Freund <andres@anarazel.de>
Cc: Stephen Frost <sfrost@snowman.net>,
 Michael Paquier <michael.paquier@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
 Tom Lane <tgl@sss.pgh.pa.us>, Claudio Freire <klaussfreire@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>,
 Sokolov Yura <funny.falcon@postgrespro.ru>,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
 Heikki Linnakangas <hlinnaka@iki.fi>,
 PostgreSQL-Dev <pgsql-hackers@postgresql.org>
References: 
 <CAL-rCA3n4Neat4pH382nuZ9v0-SCZOBJ=KHT5CoBGXim=KTAhw@mail.gmail.com>
 <CAL-rCA2cCyvapkb15fADR3qKsRMo+XimPgmGviur1ui-y0q-aQ@mail.gmail.com>
 <CAH2-WznEQBxeij1_PnczUD=vQqS0aPWOxJAkmjH_rXoBpeo0ZQ@mail.gmail.com>
 <CAL-rCA3=MiVU7SWenhPL0a3e5KfOkzvXZDp_WL+ea2Ky57Fqdg@mail.gmail.com>
 <20171128224150.syswowiaiojth7ke@alap3.anarazel.de>
 <CAH2-Wzk19G5=RxQpgfUirRvihjrMvZSMSi=u53TbMbvLj1+5vA@mail.gmail.com>
 <CAB7nPqS4JRP_xyO3YCuBktGhTkDMRvg3-WBTgLqwpnLrtx-Qzg@mail.gmail.com>
 <CAL-rCA2n7UfVu1Ui0f+7cVN4vAKVM0+-cZKb_ka6-mGQBAF92w@mail.gmail.com>
 <20180123033429.GF2416@tamriel.snowman.net>
 <9410de56-794b-147f-20f2-d5ef28e98e45@gmail.com>
 <20180301192206.2caqkwo2wzb777jq@alap3.anarazel.de>
From: Yura Sokolov <funny.falcon@gmail.com>
Message-ID: <5e5a61fc-961f-9c1a-bc28-2946812da561@gmail.com>
Date: Sun, 4 Mar 2018 12:57:45 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180301192206.2caqkwo2wzb777jq@alap3.anarazel.de>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="2Yr3GOAFWwcUBHGPEDVfewtVmZASOk2uJ"
Precedence: bulk

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--2Yr3GOAFWwcUBHGPEDVfewtVmZASOk2uJ
Content-Type: multipart/mixed; boundary="GXNfwxJf4YzoLLPMXQbJZBY3DyfDLsXaF";
 protected-headers="v1"
From: Yura Sokolov <funny.falcon@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Stephen Frost <sfrost@snowman.net>,
 Michael Paquier <michael.paquier@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
 Tom Lane <tgl@sss.pgh.pa.us>, Claudio Freire <klaussfreire@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>,
 Sokolov Yura <funny.falcon@postgrespro.ru>,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
 Heikki Linnakangas <hlinnaka@iki.fi>,
 PostgreSQL-Dev <pgsql-hackers@postgresql.org>
Message-ID: <5e5a61fc-961f-9c1a-bc28-2946812da561@gmail.com>
Subject: Re: [HACKERS] Small improvement to compactify_tuples
References: <CAL-rCA3n4Neat4pH382nuZ9v0-SCZOBJ=KHT5CoBGXim=KTAhw@mail.gmail.com>
 <CAL-rCA2cCyvapkb15fADR3qKsRMo+XimPgmGviur1ui-y0q-aQ@mail.gmail.com>
 <CAH2-WznEQBxeij1_PnczUD=vQqS0aPWOxJAkmjH_rXoBpeo0ZQ@mail.gmail.com>
 <CAL-rCA3=MiVU7SWenhPL0a3e5KfOkzvXZDp_WL+ea2Ky57Fqdg@mail.gmail.com>
 <20171128224150.syswowiaiojth7ke@alap3.anarazel.de>
 <CAH2-Wzk19G5=RxQpgfUirRvihjrMvZSMSi=u53TbMbvLj1+5vA@mail.gmail.com>
 <CAB7nPqS4JRP_xyO3YCuBktGhTkDMRvg3-WBTgLqwpnLrtx-Qzg@mail.gmail.com>
 <CAL-rCA2n7UfVu1Ui0f+7cVN4vAKVM0+-cZKb_ka6-mGQBAF92w@mail.gmail.com>
 <20180123033429.GF2416@tamriel.snowman.net>
 <9410de56-794b-147f-20f2-d5ef28e98e45@gmail.com>
 <20180301192206.2caqkwo2wzb777jq@alap3.anarazel.de>
In-Reply-To: <20180301192206.2caqkwo2wzb777jq@alap3.anarazel.de>

--GXNfwxJf4YzoLLPMXQbJZBY3DyfDLsXaF
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

01.03.2018 22:22, Andres Freund =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> Hi,
>=20
> On 2018-02-25 21:39:46 +0300, Yura Sokolov wrote:
>>> If that's the case then does it really make sense to make this change=
=2E.?
>>
>> I don't think it is really necessary to implement generic version
>> through templated.
>=20
> Why?

It is better to replace use of generic version with templated in
appropriate places.
Generic version uses variable size of element. It will be difficult to
describe through template.

>=20
>> Updated numbers are (same benchmark on same notebook, but with new
>> master, new ubuntu and later patch version) (average among 6 runs):
>>
>> master               - 16135tps
>> with templated qsort - 16199tps
>> with bucket sort     - 16956tps
>>
>> Difference is still measurable, but less significant. I don't know why=
=2E
>>
>> Rebased version of first patch (qsorted tamplate) is in atttach.
>=20
> Hm, that's a bit underwhelming. It's nice to deduplicate, but 16135tps
> -> 16199tps is barely statistically significant?

I mean bucket sort is measurably faster than both generic and templated
sort (16956 vs 16199 and 16135). So initial goal remains: to add bucket
sort in this place.

BTW, I have small change to templated version that improves sorting of
random tuples a bit (1-1.5%). Will post it a bit later with test.

> - Andres
>=20

With regards,
Yura.


--GXNfwxJf4YzoLLPMXQbJZBY3DyfDLsXaF--

--2Yr3GOAFWwcUBHGPEDVfewtVmZASOk2uJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBCAAGBQJam8MyAAoJEDiUW3vLdplxS1sH/0wEYBAgZ6nCQorPrORFxaKk
M0yJQNdiZtMIZXDEC8ol7RxqI9LUZDrR0iWDDlP4IzDCsY15w3dJ1CQtSbp2RPOX
iagFHEEHqwjWQsicNKhrRCyMcK6mi1+OJMdtTqke8cz1/tQHIc9A60yUzuMraOTb
wI68zACuyPARMUXni3Tf8d1R8SnaOmQvUK9HSMpWr3JzpN8M65FMoZ6Eeq9+MnyW
KHSGP0cjvY6otWJOWyHPolYOoIX/YhX1hMp+TeZRrgBx07FYTIKWmnO8pnuoaUeJ
V4MV3XcegZzaO6I8eWWD5fV6T/AiiyZKWdUnapyP/jJg2V7HQsTgQYRrc433sqk=
=xTW9
-----END PGP SIGNATURE-----

--2Yr3GOAFWwcUBHGPEDVfewtVmZASOk2uJ--