Subject: Re: pg_get_wal_replay_pause_state() should not return 'paused' while
 a promotion is ongoing.
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: dilipbalaut@gmail.com, michael@paquier.xyz, pgsql-hackers@postgresql.org
References: <20210519.164352.1786666023204393975.horikyota.ntt@gmail.com>
 <63ad1368-18e2-8900-8443-524bdfb1bef5@oss.nttdata.com>
 <613321d7-e629-90ac-1006-8f63b4713c8e@oss.nttdata.com>
 <20210531.171842.1230966476067802582.horikyota.ntt@gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <5e84eb9c-2987-6fef-7b31-1e7cf4d57508@oss.nttdata.com>
Date: Wed, 2 Jun 2021 12:22:04 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <20210531.171842.1230966476067802582.horikyota.ntt@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/5e84eb9c-2987-6fef-7b31-1e7cf4d57508%40oss.nttdata.com>
Precedence: bulk


On 2021/05/31 17:18, Kyotaro Horiguchi wrote:
> Sorry for missing this.
> 
> At Mon, 31 May 2021 12:52:54 +0900, Fujii Masao <masao.fujii@oss.nttdata.com> wrote in
>>
>> On 2021/05/19 19:24, Fujii Masao wrote:
>>> On 2021/05/19 16:43, Kyotaro Horiguchi wrote:
>>>> +1 for adding some tests for pg_wal_replay_pause() but the test seems
>>>> like checking only that pg_get_wal_replay_pause_state() returns the
>>>> expected state value.  Don't we need to check that the recovery is
>>>> actually paused and that the promotion happens at expected LSN?
>>> Sounds good. Attached is the updated version of the patch.
>>> I added such checks into the test.
> 
> Thanks! Looks fine. The paused-state test may get false-success but it
> would be sufficient that it detects the problem in most cases.
> 
>>> BTW, while reading some recovery regression tests, I found that
>>> 013_crash_restart.pl has "use Time::HiRes qw(usleep)" but it seems
>>> not necessary. We can safely remove that? Patch attached.
> 
> Looks just fine for the removal of HiRes usage.  All other use of
> HiRes are accompanied by a usleep usage.
> 
>> Barring any objections, I'm thinking to commit these two patches.
> 
> +1.

Thanks for the review! I pushed those two patches.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION