Feedback-ID: id4a34324:Fastmail
Date: Thu, 8 Jan 2026 10:39:41 -0500
From: Andres Freund <andres@anarazel.de>
To: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-hackers@lists.postgresql.org, 
	Greg Sabino Mullane <htamfids@gmail.com>
Subject: Re: [PATCH] Provide support for trailing commas
Message-ID: <5ecvumscakju32sxnautb4dpqoz2vrbklko4kxg6f3zu7rx323@vtger6sdhl3r>
References: <CAKAnmmKVwP=yr8t8p8_QtrBFjyENLZyPxscJh4UrkCeqMQuhrw@mail.gmail.com>
 <aV82LTMd1I3GOdiX@momjian.us>
 <86BF995D-5959-458C-8F63-DDDB250B058B@anarazel.de>
 <aV_HOurziLsdyhuV@momjian.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aV_HOurziLsdyhuV@momjian.us>
Archived-At: <https://www.postgresql.org/message-id/5ecvumscakju32sxnautb4dpqoz2vrbklko4kxg6f3zu7rx323%40vtger6sdhl3r>
Precedence: bulk

Hi,

On 2026-01-08 10:03:22 -0500, Bruce Momjian wrote:
> On Thu, Jan  8, 2026 at 12:51:14AM -0500, Andres Freund wrote:
> > Hi, 
> > 
> > On January 7, 2026 11:44:29 PM EST, Bruce Momjian <bruce@momjian.us> wrote:
> > >On Tue, Jan  6, 2026 at 03:35:38PM -0500, Greg Sabino Mullane wrote:
> > >> tl;dr Provide support for trailing commas, where possible and practical.
> > >> 
> > >> (Disclaimer: No LLM or AI was used to craft this patch or this email)
> > >> 
> > >> Happy New Year! Please find attached a patch to provide comprehensive trailing
> > >> comma support, where we allow (when possible) a comma that does NOT come before
> > >> the next item in a list. To wit:
> > >
> > >I am unclear why you bothered to create and work on such a large email
> > >and patch rather than ask if this was a desired change;  see:
> > >
> > >	https://wiki.postgresql.org/wiki/Todo#Development_Process
> > 
> > Meh. This kind of change really needs information about the
> > implementation cost to be judged. The process described there rarely is
> > a good idea for anybody that has some community experience.
> 
> I disagree.  It was clear in this case that it was the concept that was
> not wanted, rather than the implementation cost.

I don't agree with that, fwiw. I it were easy to implement, I think we ought
to allow trailing commas in many places, most importantly the select list and
from list.

Greetings,

Andres Freund