Content-Type: multipart/mixed; boundary="------------3TzcjImdxrnaedrXK7xCJbHf"
Message-ID: <5eeabd10-1aff-ea61-f92d-9fa0d9a7e207@gmail.com>
Date: Tue, 20 Sep 2022 08:41:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: pg_create_logical_replication_slot argument incongruency
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org
References: 
 <CA+HEvJDmFSKmqaXYuPNjkGpTboE35s_PifOg2AqwVJBn5rWGzw@mail.gmail.com>
 <YykYZI8RChKycDe9@paquier.xyz>
From: Florin Irion <irionr@gmail.com>
In-Reply-To: <YykYZI8RChKycDe9@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/5eeabd10-1aff-ea61-f92d-9fa0d9a7e207%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------3TzcjImdxrnaedrXK7xCJbHf
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 20/09/22 03:33, Michael Paquier wrote:
> On Mon, Sep 19, 2022 at 07:02:16PM +0200, Florin Irion wrote:
>> This was introduced in commit 19890a06.
>>
>> IMHO we should use the documented argument name `two_phase` and change the
>> function to accept it.
>>
>> What do you think?
> 
> 19890a0 is included in REL_14_STABLE, and changing an argument name is
> not acceptable in a stable branch as it would imply a catversion
> bump.  Let's change the docs so as we document the parameter as
> "twophase", instead.
> --
> Michael

I understand. 

OK, patch only for the docs attached.

Cheers, 
Florin
www.enterprisedb.com
--------------3TzcjImdxrnaedrXK7xCJbHf
Content-Type: text/plain; charset=UTF-8; name="two_phase_slot_v2.patch"
Content-Disposition: attachment; filename="two_phase_slot_v2.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9mdW5jLnNnbWwgYi9kb2Mvc3JjL3NnbWwvZnVu
Yy5zZ21sCmluZGV4IGY2M2EwNGM2NjcuLmYxYThhOWEwYmEgMTAwNjQ0Ci0tLSBhL2RvYy9z
cmMvc2dtbC9mdW5jLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2Z1bmMuc2dtbApAQCAtMjU4
OTEsNyArMjU4OTEsNyBAQCBwb3N0Z3Jlcz0jIFNFTEVDVCAqIEZST00gcGdfd2FsZmlsZV9u
YW1lX29mZnNldChwZ19zdG9wX2JhY2t1cCgpKTsKICAgICAgICAgPGluZGV4dGVybT4KICAg
ICAgICAgIDxwcmltYXJ5PnBnX2NyZWF0ZV9sb2dpY2FsX3JlcGxpY2F0aW9uX3Nsb3Q8L3By
aW1hcnk+CiAgICAgICAgIDwvaW5kZXh0ZXJtPgotICAgICAgICA8ZnVuY3Rpb24+cGdfY3Jl
YXRlX2xvZ2ljYWxfcmVwbGljYXRpb25fc2xvdDwvZnVuY3Rpb24+ICggPHBhcmFtZXRlcj5z
bG90X25hbWU8L3BhcmFtZXRlcj4gPHR5cGU+bmFtZTwvdHlwZT4sIDxwYXJhbWV0ZXI+cGx1
Z2luPC9wYXJhbWV0ZXI+IDx0eXBlPm5hbWU8L3R5cGU+IDxvcHRpb25hbD4sIDxwYXJhbWV0
ZXI+dGVtcG9yYXJ5PC9wYXJhbWV0ZXI+IDx0eXBlPmJvb2xlYW48L3R5cGU+LCA8cGFyYW1l
dGVyPnR3b19waGFzZTwvcGFyYW1ldGVyPiA8dHlwZT5ib29sZWFuPC90eXBlPiA8L29wdGlv
bmFsPiApCisgICAgICAgIDxmdW5jdGlvbj5wZ19jcmVhdGVfbG9naWNhbF9yZXBsaWNhdGlv
bl9zbG90PC9mdW5jdGlvbj4gKCA8cGFyYW1ldGVyPnNsb3RfbmFtZTwvcGFyYW1ldGVyPiA8
dHlwZT5uYW1lPC90eXBlPiwgPHBhcmFtZXRlcj5wbHVnaW48L3BhcmFtZXRlcj4gPHR5cGU+
bmFtZTwvdHlwZT4gPG9wdGlvbmFsPiwgPHBhcmFtZXRlcj50ZW1wb3Jhcnk8L3BhcmFtZXRl
cj4gPHR5cGU+Ym9vbGVhbjwvdHlwZT4sIDxwYXJhbWV0ZXI+dHdvcGhhc2U8L3BhcmFtZXRl
cj4gPHR5cGU+Ym9vbGVhbjwvdHlwZT4gPC9vcHRpb25hbD4gKQogICAgICAgICA8cmV0dXJu
dmFsdWU+cmVjb3JkPC9yZXR1cm52YWx1ZT4KICAgICAgICAgKCA8cGFyYW1ldGVyPnNsb3Rf
bmFtZTwvcGFyYW1ldGVyPiA8dHlwZT5uYW1lPC90eXBlPiwKICAgICAgICAgPHBhcmFtZXRl
cj5sc248L3BhcmFtZXRlcj4gPHR5cGU+cGdfbHNuPC90eXBlPiApCkBAIC0yNTkwNCw3ICsy
NTkwNCw3IEBAIHBvc3RncmVzPSMgU0VMRUNUICogRlJPTSBwZ193YWxmaWxlX25hbWVfb2Zm
c2V0KHBnX3N0b3BfYmFja3VwKCkpOwogICAgICAgICB0aGUgc2xvdCBzaG91bGQgbm90IGJl
IHBlcm1hbmVudGx5IHN0b3JlZCB0byBkaXNrIGFuZCBpcyBvbmx5IG1lYW50CiAgICAgICAg
IGZvciB1c2UgYnkgdGhlIGN1cnJlbnQgc2Vzc2lvbi4gVGVtcG9yYXJ5IHNsb3RzIGFyZSBh
bHNvCiAgICAgICAgIHJlbGVhc2VkIHVwb24gYW55IGVycm9yLiBUaGUgb3B0aW9uYWwgZm91
cnRoIHBhcmFtZXRlciwKLSAgICAgICAgPHBhcmFtZXRlcj50d29fcGhhc2U8L3BhcmFtZXRl
cj4sIHdoZW4gc2V0IHRvIHRydWUsIHNwZWNpZmllcworICAgICAgICA8cGFyYW1ldGVyPnR3
b3BoYXNlPC9wYXJhbWV0ZXI+LCB3aGVuIHNldCB0byB0cnVlLCBzcGVjaWZpZXMKICAgICAg
ICAgdGhhdCB0aGUgZGVjb2Rpbmcgb2YgcHJlcGFyZWQgdHJhbnNhY3Rpb25zIGlzIGVuYWJs
ZWQgZm9yIHRoaXMKICAgICAgICAgc2xvdC4gQSBjYWxsIHRvIHRoaXMgZnVuY3Rpb24gaGFz
IHRoZSBzYW1lIGVmZmVjdCBhcyB0aGUgcmVwbGljYXRpb24KICAgICAgICAgcHJvdG9jb2wg
Y29tbWFuZCA8bGl0ZXJhbD5DUkVBVEVfUkVQTElDQVRJT05fU0xPVCAuLi4gTE9HSUNBTDwv
bGl0ZXJhbD4uCg==

--------------3TzcjImdxrnaedrXK7xCJbHf--