Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tiTxQ-00GWTe-T1 for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Feb 2025 07:48:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tiTxP-003jCc-00 for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Feb 2025 07:48:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tiTxO-003jBq-Hk for pgsql-hackers@lists.postgresql.org; Thu, 13 Feb 2025 07:48:23 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tiTxL-000XlO-2z for pgsql-hackers@postgresql.org; Thu, 13 Feb 2025 07:48:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1739432896; bh=tb6ErMbw5ZwJ2yx8T3VFqw34El92gZwN3Si7TMWsS9o=; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From: In-Reply-To:From; b=C3tV0nF0ZAfxJTr6zMPbSCuSo0b+qYI0L0ihXEg0b3XVCb90uEufw07VDShNARNRk l6LkpVWTXWR3oGoMCSJKa4TVoBEirzVEamzRITLW/9XICkls4Th8O83ZDlFuQwoeHu XgUlZGIZlqgnoOGamgr6QirZmfsv/w4R/7DihlLy+BfzFmidJsYLQ/9NDIJm8MPsdS jifzVzGLtSmif8m49XQIe6xtnR2fi1aeKZGGNGKiVPjQV9JpTi4kHaOtIa/MwvTmrJ wUIFg28EZcQe4xD1oTqBtYIMJR7/d3X9tsf8eSJMTy2L8/P49PE0qdQk1SWlDcmxTq Tu05wzXRVxOgA== Received: from [172.30.56.6] (unknown [213.171.56.12]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: a.melnikov@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id 259C360137; Thu, 13 Feb 2025 10:48:16 +0300 (MSK) Message-ID: <5ef9fb1c-2e5a-489e-85f5-ba7ac6159577@postgrespro.ru> Date: Thu, 13 Feb 2025 10:48:15 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Change GUC hashtable to use simplehash? To: John Naylor Cc: Tom Lane , Jeff Davis , Ants Aasma , Heikki Linnakangas , Junwang Zhao , jian he , Andres Freund , Gurjeet Singh , pgsql-hackers@postgresql.org References: <2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com> <0647027b-9c9a-4f16-8f7c-3f9f3eb9451e@postgrespro.ru> <1520769.1736991361@sss.pgh.pa.us> <16198d33-a4e2-46db-b6c3-494367f5816d@postgrespro.ru> <4c739718-27d6-44fe-9113-56a251c13275@postgrespro.ru> <42304488-65ce-4604-854e-2aaf3bc8f09d@postgrespro.ru> Content-Language: en-US From: "Anton A. Melnikov" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-KSMG-AntiPhishing: NotDetected, bases: 2025/02/13 06:58:00 X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2025/02/13 05:44:00 #27202047 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi! On 13.02.2025 09:03, John Naylor wrote: > > Three weeks ago, you said "Agreed that reverting seems as a preferable > way, and here's why." I assumed that meant you tested it, so my > mistake. I'll take a look. > Sorry! I was wrong not to express my thoughts clearly here. I meant revert in a common sense. Maybe before the optimization started at all, because there was the fastest result on short lines. Although it is unknown how it will be in reality and it could be worse than optimization with some fixes. With the best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company