Message-ID: <5f77dc57-0753-4177-a917-e56a875fdff0@iki.fi>
Date: Mon, 16 Feb 2026 09:51:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Refactoring postmaster's code to cleanup after child exit
To: Michael Banck <mbanck@gmx.net>
Cc: =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
 Thomas Munro <thomas.munro@gmail.com>, Andres Freund <andres@anarazel.de>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <CA+hUKGKWqSFoJXzRC9D0owFj1Xby0qvWr-k6p8z9gQzT7+nr7w@mail.gmail.com>
 <e9e58efa-a364-4f4f-b112-a11d62af952a@iki.fi>
 <a102f15f-eac4-4ff2-af02-f9ff209ec66f@iki.fi>
 <ebhz2viw6sioxwlhborufqpjbg7ktckgyfplxevh6wfaiesavz@iwzka6fyohev>
 <8e9424ae-2537-411a-a4cd-79760494186e@iki.fi>
 <b892e94c-3511-435a-bc2b-48e052589c16@iki.fi>
 <CA+hUKGLLtH0ZT3+7i9xJzY8wufmqA7y4q9uC2TsGcBHBuRX4sA@mail.gmail.com>
 <217d43af-0287-4769-a825-cde4cfa00e6c@iki.fi>
 <87ttdq9vl5.fsf@wibble.ilmari.org>
 <4001dd8d-a65e-4c8d-900c-bdacd55b083a@iki.fi>
 <69917fde.df0a0220.33b3c5.f45aSMTPIN_ADDED_BROKEN@mx.google.com>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <69917fde.df0a0220.33b3c5.f45aSMTPIN_ADDED_BROKEN@mx.google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/5f77dc57-0753-4177-a917-e56a875fdff0%40iki.fi>
Precedence: bulk

On 15/02/2026 10:11, Michael Banck wrote:
> On Tue, Oct 08, 2024 at 12:55:00AM +0300, Heikki Linnakangas wrote:
>> In the meanwhile, here is a one more version of the test patches, with a
>> SKIP that checks that IO::Socket::UNIX works.
> 
> I've only realized recently, but those postmaster tap tests have been
> failing during Debian package build (see e.g. [0]) on hurd-i386/amd64 with
> 
> |send: Cannot determine peer address at t/002_connection_limits.pl line 136.
> 
> This wasn't widely noticed because both architectures are on the (not
> small) list of arches where test suite failures are ignored[1] but I
> think nowadays it is the only (or one of the very few) remaining
> issue(s). I encountered it now when I tried to turn on
> --enable-tap-tests on fruitcrow.
> 
> The Perl code run through strace shows it runs connect(), then
> getpeername() and then sendto(), as seen here[2]. However, getpeername()
> on Unix sockets is not implemented on the Hurd yet[3] (granted, FSVO
> "yet", the issue is 20 years old). I've opened an issue in Perl asking
> to work around this here: https://github.com/Perl/perl5/issues/24195
> 
> Would something like the attached be acceptable in the interim to have
> this test be skipped on the Hurd as well?

Hmm, so is the "$sock->send('foo');" actually necessary, if the error 
occurs on getpeername() already? Where does the getpeername() call come 
from?

It would be nice to silence that failure one way or another. If we go 
with this approach, would need a comment at least to explain it.

It seems a little awkward to send garbage to the server for this. Could 
we replace the send() with a non-blocking recv() or something?

- Heikki