Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pd6ZO-0001tf-1s for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Mar 2023 09:40:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pd6ZM-0004ZF-TI for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Mar 2023 09:40:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pd6ZL-0004Yw-VX for pgsql-hackers@lists.postgresql.org; Fri, 17 Mar 2023 09:40:16 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pd6ZI-0004AG-7X for pgsql-hackers@postgresql.org; Fri, 17 Mar 2023 09:40:15 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 171F7581FB9; Fri, 17 Mar 2023 05:40:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 17 Mar 2023 05:40:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679046009; x=1679053209; bh=RmS0kg2RChhCUnPrxpYufbmX0FAbJBqxAmz xnlPhOwM=; b=vhbS8WAaaOHJpmd6i0OL4KprQ3+KpioL3AJoRrxw8hl5jAx9cZu QDy0NuWuAxlRhP2gDwl/KAd88CHenK+nSPTmsFql4murenKNmevuNi3VFycIlsJf rpjNoOhofWoq2L5lnCr0ppvQeja8DKgSojvuHNXBAyqTncDTFsSQHimflNFIjUOl 84nSLjPc5gdKSoOEofaz5PooRZ2asNOR63LJBZdQAx7g3T0UFSkblxvoJinR49Mo r9BVoh25DCafFWqYdiXUtGVATyubsKQcjTyo6qf+CirjEWVPT+IjHdgFrnKAq7qx J5UK81XxKj3Mcn03lJlKOOV/FC+4AuH8myw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefvddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehleffgeegudejteei hfelteduvdeifffhffdvjedvffegjeekudeludehudeifeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Mar 2023 05:40:07 -0400 (EDT) Message-ID: <5fb0d46e-d04d-fd9b-08c6-30c0538be0f4@enterprisedb.com> Date: Fri, 17 Mar 2023 10:40:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: improving user.c error messages Content-Language: en-US To: Nathan Bossart Cc: Alvaro Herrera , Tom Lane , Robert Haas , "pgsql-hackers@postgresql.org" References: <20230220190210.GA3481922@nathanxps13> <20230220225852.GA3940888@nathanxps13> <20230309175846.GA3626988@nathanxps13> <20230310000313.GA3992372@nathanxps13> <20230316154858.GA791987@nathanxps13> <73ab0059-a652-e44a-73c6-36f350782078@enterprisedb.com> <20230316162749.GA792895@nathanxps13> <20230316234701.GA903298@nathanxps13> From: Peter Eisentraut In-Reply-To: <20230316234701.GA903298@nathanxps13> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 17.03.23 00:47, Nathan Bossart wrote: > Here is a rebased patch in which I've addressed the latest feedback except > for the DropRole() part that is under discussion. committed