To: Postgres hackers <pgsql-hackers@postgresql.org>
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Subject: bugfifx: a minor mistake in brin_inclusion.c comment
Message-ID: <5ff514f2-8b1e-6366-b11c-8e2ed442562d@2ndquadrant.com>
Date: Fri, 23 Mar 2018 01:32:55 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------DE2017399FFB9E3976DA035D"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------DE2017399FFB9E3976DA035D
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hi,

while looking at brin_inclusion.c, I've noticed that the comment about
INCLUSION_UNMERGEABLE and INCLUSION_CONTAINS_EMPTY uses incorrect values
(1 instead of 2). Attached is a simple fix.

But perhaps it would be better to use the constants in the comment.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--------------DE2017399FFB9E3976DA035D
Content-Type: text/x-patch;
 name="brin-inclusion-doc-fix.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="brin-inclusion-doc-fix.patch"

diff --git a/src/backend/access/brin/brin_inclusion.c b/src/backend/access/brin/brin_inclusion.c
index 2542877..d8042b0 100644
--- a/src/backend/access/brin/brin_inclusion.c
+++ b/src/backend/access/brin/brin_inclusion.c
@@ -60,9 +60,9 @@
  * The values stored in the bv_values arrays correspond to:
  *
  * 0 - the union of the values in the block range
- * 1 - whether an empty value is present in any tuple in the block range
- * 2 - whether the values in the block range cannot be merged (e.g. an IPv6
+ * 1 - whether the values in the block range cannot be merged (e.g. an IPv6
  *	   address amidst IPv4 addresses).
+ * 2 - whether an empty value is present in any tuple in the block range
  */
 #define INCLUSION_UNION				0
 #define INCLUSION_UNMERGEABLE		1

--------------DE2017399FFB9E3976DA035D--