Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hnQ0m-0002TT-Uw for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Jul 2019 16:09:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hnQ0l-0002Xl-Py for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Jul 2019 16:09:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hnQ0l-0002VR-CH for pgsql-hackers@lists.postgresql.org; Tue, 16 Jul 2019 16:09:03 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1hnQ0j-0000e7-7Z for pgsql-hackers@lists.postgresql.org; Tue, 16 Jul 2019 16:09:02 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x6GG8rxP006024; Tue, 16 Jul 2019 12:08:53 -0400 From: Tom Lane To: Robert Haas cc: David Steele , David Rowley , Jesper Pedersen , Andres Freund , PostgreSQL Hackers Subject: Re: POC: converting Lists into arrays In-reply-to: References: <481.1551390571@sss.pgh.pa.us> <437.1551637744@sss.pgh.pa.us> <12684.1551723095@sss.pgh.pa.us> <20190304190612.vgqqsowzkrh22623@alap3.anarazel.de> <26464.1551734920@sss.pgh.pa.us> <20190304221101.hdg4vj5fo4eewh3b@alap3.anarazel.de> <20190304235402.nod3gbotk2qtd4nh@alap3.anarazel.de> <1131.1551746172@sss.pgh.pa.us> <14626.1558745627@sss.pgh.pa.us> <29297.1558799327@sss.pgh.pa.us> <25178.1562006685@sss.pgh.pa.us> <25258.1562023641@sss.pgh.pa.us> <2305.1562181615@sss.pgh.pa.us> <29361.1563220190@sss.pgh.pa.us> <2420.1563246458@sss.pgh.pa.us> <9727.1563288281@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Tue, 16 Jul 2019 12:01:38 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6022.1563293333.1@sss.pgh.pa.us> Date: Tue, 16 Jul 2019 12:08:53 -0400 Message-ID: <6023.1563293333@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Robert Haas writes: > On Tue, Jul 16, 2019 at 10:44 AM Tom Lane wrote: >> OK, I'm outvoted, will do it that way. > I cast my vote in the other direction i.e. for sticking with qsort. Didn't see this until after pushing a commit that uses "list_sort". While composing that commit message another argument occurred to me, which is that renaming makes it absolutely sure that any external callers will notice they have an API change to deal with, no matter how forgiving their compiler is. Also, if somebody really really doesn't want to cope with the change, they can now make their own version of list_qsort (stealing it out of 1cff1b95a) and the core code won't pose a conflict. So I'm good with "list_sort" at this point. regards, tom lane