DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	b=iwt4WFPnEPH2oX0DcR7ZYBF2UX/QBjnZ8dMz2AIOm5CeyFWDLnUgkQnlHSMzmMuTv8
	wY9Y4Qfh+yJdE4YZMdFljhnEsUDSxYLmOmB3QQ9eg0iU1jW0QsT6le9gNpuRn8YHz5H+
	K5v+ybV476MOfJR1JnmCFQesHlpbSkAgabq4Q=
MIME-Version: 1.0
In-Reply-To: <5543.1244218518@sss.pgh.pa.us>
References: <20090526144812.GC15213@yugib.highrise.ca>
	<e51f66da0906030720u33d72d05y14ea5ce002cbaf1e@mail.gmail.com>
	<20090604114610.808217tbogts0noi@mail.bluegap.ch>
	<4A283A8D.8030600@cheapcomplexdevices.com>
	<20090605090514.11712ntlvhi2deay@mail.bluegap.ch>
	<2871.1244209112@sss.pgh.pa.us>
	<603c8f070906050829m1eaaa969tff7ca85d04018c5a@mail.gmail.com>
	<4888.1244216273@sss.pgh.pa.us>
	<603c8f070906050859t41595fb1n17ed6084711b542e@mail.gmail.com>
	<5543.1244218518@sss.pgh.pa.us>
Date: Fri, 5 Jun 2009 12:20:56 -0400
Message-ID: <603c8f070906050920h6842bf91q6ef2ec22e2948eb0@mail.gmail.com>
Subject: Re: PostgreSQL Developer meeting minutes up
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Markus Wanner <markus@bluegap.ch>,
	Ron Mayer <rm_pg@cheapcomplexdevices.com>,
	Marko Kreen <markokr@gmail.com>, Greg Stark <stark@enterprisedb.com>,
	Andres Freund <andres@anarazel.de>, Aidan Van Dyk <aidan@highrise.ca>,
	Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	Magnus Hagander <magnus@hagander.net>,
	Andrew Dunstan <andrew@dunslane.net>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 5, 2009 at 12:15 PM, Tom Lane<tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> [ about micro commits ]
>> (As a side benefit, if one of my little micro-commits turns out to
>> have a bug, you can easily revert *just that commit*, without having
>> to manually sort out exactly which pieces related to that change.)
>
> I don't actually have a lot of faith in such an approach. =A0My experienc=
e
> is that bugs arise from unforeseen interactions of changes, and that
> "backing out just one" isn't a useful thing to do, even if none of the
> later parts of the patch directly depend on it.
>
> So, yeah, presenting a patch as a series of edits can be useful for
> review purposes, but I'm not at all excited about cluttering the
> long-term project history with a zillion micro-commits. =A0One of the
> things I find most annoying about reviewing the current commit history
> is that Bruce has taken a micro-commit approach to managing the TODO
> list --- I was seldom so happy as the day that disappeared from CVS,
> because of the ensuing reduction in noise level.

I've never even noticed that noise, even when reviewing older history.
 The power of "git log" to get you exactly the commits you care about
is not to be underestimated.

With regard to micro-commits, I don't have hugely strong feelings on
the issue.  I like them in certain situations, and I think that git
makes it feasible to use them that way if you want to; but if you
don't want to, I don't think that's a disaster either.

...Robert