Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 8FCCF632FB3 for ; Tue, 29 Sep 2009 10:42:12 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 75264-04 for ; Tue, 29 Sep 2009 13:41:53 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-fx0-f225.google.com (mail-fx0-f225.google.com [209.85.220.225]) by mail.postgresql.org (Postfix) with ESMTP id 7A66663457B for ; Tue, 29 Sep 2009 10:42:01 -0300 (ADT) Received: by fxm25 with SMTP id 25so2851947fxm.24 for ; Tue, 29 Sep 2009 06:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=HChOTckuQnwAjd8nWqx4Qzdz0UN0FXYK/kHHL56Wkjw=; b=hYuag569GzJ5OZqFrpHVyrsMlhRGcPqhMAnTwcJhABKSUq+DviKJNlO5aFt0M+Ygq9 x4FPl2YN409AC3vnionOWCEfe1BHehHDnrByc+pbuOoE88qnviWufv/K8iWz4X/0JImN i8cBNNDHK/iTpNJBZXVmIonP3HVKQN/G+QoGo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Vd89zrji6WPvHY2CCTmp8j3Sw07F44CZT+ElawMnooAYyUS10zB2YwFr9yIXHmb3mO stDZJd+zYKLEKSichAlLDxXoG2AN5Za917STp3SNq4fwEseigf7Nr2tT6WqgFRo/nasZ XJnKZjH78yekoUZPt1UHp9rdNGF0DEMPUKZt0= MIME-Version: 1.0 Received: by 10.239.141.143 with SMTP id c15mr411909hba.47.1254231718683; Tue, 29 Sep 2009 06:41:58 -0700 (PDT) In-Reply-To: <20090929105431.GO17756@tamriel.snowman.net> References: <20090929105431.GO17756@tamriel.snowman.net> Date: Tue, 29 Sep 2009 09:41:58 -0400 Message-ID: <603c8f070909290641r62a5205ama3fbc98f98133fe0@mail.gmail.com> Subject: Re: [PATCH] Reworks for Access Control facilities (r2311) From: Robert Haas To: Stephen Frost Cc: KaiGai Kohei , KaiGai Kohei , pgsql-hackers@postgresql.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.576 tagged_above=-10 required=5 tests=AWL=0.023, BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 200909/1864 X-Sequence-Number: 146670 On Tue, Sep 29, 2009 at 6:54 AM, Stephen Frost wrote: > * KaiGai Kohei (kaigai@ak.jp.nec.com) wrote: >> Could you post any review comments, even if it is not comprehensive yet? > > In general, you don't need to preface your comments with 'MEMO:'. =A0I > would encourage removing that. =A0You might use 'FIXME:' instead, if it i= s > something which needs to be corrected in the future. =A0Additionally, > please think about PG as a whole project. =A0Talking about 'native > privilege mechanism' implies there are 'native' and 'foreign' ones. =A0I > would recommend using the term 'default' instead. Or maybe 'standard'? ...Robert