DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	b=lUP/USPZw3NhF9x80c7sAe7M2hQsDLbyRhXTtklaU4txxr7tjYZnBi93zEEonmeQ8F
	t4oREfy0qJeFeI4Ft+bRB5GaR5jbg7cAN+R/fcxzC3hvjQuB7GS5Xz4dxkPvDDO4K3ib
	++Zo8iyJ6Y92UvTidwxcNsVQM7EIo+1uxbHnA=
MIME-Version: 1.0
In-Reply-To: <4B3B6AE9.1000901@sigaev.ru>
References: <4B0AC9E1.5050509@sigaev.ru> <4B0EAE0D.606@sigaev.ru>
	<603c8f070912292255u30e1983bi22ed5778bd2ce890@mail.gmail.com>
	<4B3B6AE9.1000901@sigaev.ru>
Date: Wed, 30 Dec 2009 12:16:41 -0500
Message-ID: <603c8f070912300916k5cc252b9ia217076dcb2e9aea@mail.gmail.com>
Subject: Re: KNNGiST for knn-search (WIP)
From: Robert Haas <robertmhaas@gmail.com>
To: Teodor Sigaev <teodor@sigaev.ru>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2009/12/30 Teodor Sigaev <teodor@sigaev.ru>:
>> changes should be made. =A0It does also need to be updated to CVS HEAD,
>> as it no longer applies cleanly.
>
> The reason was a point_ops patch, some OIDs become duplicated. Both attac=
hed
> patches are synced with current CVS.

Thanks!  I will take a look.

>> I tend to feel that we should probably target this for 8.6 rather than
>> 8.5. =A0We are down to the last CommitFest, and while we don't have a
>> nailed-down criterion for what is "too big" for the last CommitFest of
>> a given release cycle, this is definitely a big, invasive patch. =A0This
>
> Is we really have rule to accept only small patches at last CommitFest? M=
ay
> be, FixFest name is better for it? :)

See here and following for some of the previous discussion - which was
not unanimous on all points:

http://archives.postgresql.org/pgsql-hackers/2009-09/msg00139.php

I think the intention is not to accept only bug fixes, but to limit
large features to those that have already been through a CommitFest or
two.

> Actually, it's easy to split patch to several ones:
> - contrib/pg_trgm
> - contrib/btree_gist
> - knngist itself
> - planner changes
>
> And knngist depends on rbtree and point_ops patch, in summary 6 dependent
> patches. Is it more comfortable?

I'm not sure. One of the problems with separating out contrib module
changes is that it tends to obscure the point of the changes to the
core code.  On the other hand if some of the core code changes can be
split out into an infrastructure patch that is of some independent
usefulness, that can certainly be worthwhile.  It's not obvious to me
without looking at this more than I have whether there is a possble
split that makes sense here; I will read your updated patch.

...Robert