DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	b=s+CYdc41HgY8VLU4NYIirV8NK/Gg7KmrstpP7t3hlSo3joevcquZ8yC4YRpiz622UT
	C7J4ec5jK1PKrnQnqBRgVQhq8wCMs8XKNCowzyHVbbHJUq0fe3kWHYarDdooG9gSrsw0
	7oWy88qH4Ms2fUnCj1wwcatwiABVaIDrzPcek=
MIME-Version: 1.0
In-Reply-To: <3073cc9b1003290823g52615893j8183d6e70fb510d6@mail.gmail.com>
References: <1269851630.3684.3636.camel@ebony>
	<603c8f071003290637q14d431f7j90afabd6fd2ec952@mail.gmail.com>
	<12679.1269873374@sss.pgh.pa.us>
	<20100329144219.GA3925@alvh.no-ip.org>
	<3073cc9b1003290823g52615893j8183d6e70fb510d6@mail.gmail.com>
Date: Mon, 29 Mar 2010 11:29:25 -0400
Message-ID: <603c8f071003290829r1f41609cs1d5c35b19fcb47bc@mail.gmail.com>
Subject: Re: enable_joinremoval
From: Robert Haas <robertmhaas@gmail.com>
To: Jaime Casanova <jcasanov@systemguards.com.ec>
Cc: Alvaro Herrera <alvherre@commandprompt.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Simon Riggs <simon@2ndquadrant.com>, pgsql-hackers@postgresql.org
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Mar 29, 2010 at 11:23 AM, Jaime Casanova
<jcasanov@systemguards.com.ec> wrote:
> On Mon, Mar 29, 2010 at 10:42 AM, Alvaro Herrera
> <alvherre@commandprompt.com> wrote:
>>
>> It seems that what's really needed is some debug output to be able to
>> find out what it did.
>
> +1, i was preparing an env for testing this but in the while i was
> thinking how can i know what happens... counting the tables in the
> explain analyze? it's possible but not ideal

I don't actually see much value in making EXPLAIN show which tables
were removed.  The usefulness of doing that presumes that the user is
asking a particular and very specific question, namely, exactly which
tables got removed?, or perhaps, did this particular table get
removed?  The latter question is not too hard to figure out anyway -
just look for that table in the query.  The former is a little harder
but if you really need to know you can always look at which tables
WERE referenced and work backwards from there, or write a little
script to post-process the JSON, XML, or YAML output.  Of course
sometimes it would be handy to have but if we start adding too many
bells and whistles to the EXPLAIN output it will get cluttered and
unuseful.

I think the value of an enable_joinremoval switch is that it lets
someone throw the switch and see how the plan changes.  It might
change in a very simple way or it might have a dramatic effect on the
whole plan.

...Robert